Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Error Page #968

Open
KevinWu098 opened this issue Apr 22, 2024 · 6 comments
Open

Create an Error Page #968

KevinWu098 opened this issue Apr 22, 2024 · 6 comments
Assignees
Labels
enhancement Improvements to the user experience medium Medium priority issue

Comments

@KevinWu098
Copy link
Member

KevinWu098 commented Apr 22, 2024

We should handle errors more cleanly than allowing the default error page to show to the user.

One error that pops to mind is the dynamic module issue (when we update the site, but users still have an older version of the site open).

Screenshot 2024-06-03 at 2 40 56 PM
@KevinWu098 KevinWu098 added enhancement Improvements to the user experience medium Medium priority issue labels Apr 22, 2024
@JackyZzZz
Copy link
Contributor

For update, do you mean when we merge new commits into the production?

@JackyZzZz
Copy link
Contributor

And we notify the user that they should update or refresh the page to catch up? Is that something you are referring to?

@KevinWu098
Copy link
Member Author

For update, do you mean when we merge new commits into the production?

Yup; I was told that the reason why we sometimes see a dynamic module not imported error is that the site was updated

But that’s not specifically what this issue wants to cover; in general, we should have our own custom error page rather than the generic

@JackyZzZz
Copy link
Contributor

Could you give an example of when a generic error page triggers lol. I haven't look into it but it sounds like an interesting issue

@KevinWu098
Copy link
Member Author

Could you give an example of when a generic error page triggers lol. I haven't look into it but it sounds like an interesting issue

My understanding is that the error about dynamic import of module is caused when you have an outdated/cached version of the site? It's not something we can fix, I don't think, but if you've ever seen a gray screen with a white bar saying something about a JS import, that's what I'm talking about.

As for the fix, this issue is mainly suggesting that we mitigate user confusion with a more proper error page (perhaps with bonus text for common errors/why they happen)

@JackyZzZz JackyZzZz self-assigned this Apr 30, 2024
@MinhxNguyen7
Copy link
Member

@JackyZzZz To be clear, it doesn't really matter what triggers the error. We just need to have an error page for when something happens and what they should do (try to reload).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the user experience medium Medium priority issue
Projects
Status: Backlog 🥱
Development

No branches or pull requests

3 participants