Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Usage support to Number Skeletons. #33

Merged
merged 2 commits into from Jul 16, 2020
Merged

Add Unit Usage support to Number Skeletons. #33

merged 2 commits into from Jul 16, 2020

Conversation

hugovdm
Copy link
Collaborator

@hugovdm hugovdm commented Jul 15, 2020

Checklist

@hugovdm hugovdm requested review from sffc and younies July 15, 2020 22:45
@hugovdm hugovdm linked an issue Jul 15, 2020 that may be closed by this pull request
Implement usage skeletons #14
Closed
sffc
sffc reviewed Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Just some small things.

icu4c/source/i18n/number_skeletons.cpp Outdated Show resolved Hide resolved
icu4c/source/i18n/number_skeletons.cpp Outdated Show resolved Hide resolved
icu4c/source/i18n/number_skeletons.h Outdated Show resolved Hide resolved
icu4c/source/i18n/unitsdata.cpp Outdated Show resolved Hide resolved
icu4c/source/test/intltest/numbertest_api.cpp Outdated Show resolved Hide resolved
icu4c/source/test/intltest/numbertest_api.cpp Outdated Show resolved Hide resolved
sffc
sffc requested changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(setting review bit)

@hugovdm hugovdm requested a review from sffc July 16, 2020 00:31
@hugovdm hugovdm merged commit 3cf2322 into units-staging Jul 16, 2020
@hugovdm hugovdm deleted the skeleton branch July 16, 2020 08:56
@hugovdm hugovdm added this to the 2020-Q3-m2 milestone Jul 17, 2020
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 21, 2020
@hugovdm
PR: icu-units#33
2e917bc 
Commit: 3cf2322

Add Unit Usage support to Number Skeletons.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: icu-units#33
03b62fc 
Commit: 3cf2322

Add Unit Usage support to Number Skeletons.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: icu-units#33
12138b4 
Commit: 3cf2322

Add Unit Usage support to Number Skeletons.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: icu-units#33
20c9d34 
Commit: 3cf2322

Add Unit Usage support to Number Skeletons.
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
Add Unit Usage support to Number Skeletons.
6b0601d 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
Add Unit Usage support to Number Skeletons.
1a62b3b 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 15, 2020
@hugovdm
Add Unit Usage support to Number Skeletons.
d5070f3 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 28, 2020
@hugovdm
Add Unit Usage support to Number Skeletons.
b2a338b 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 1, 2020
@hugovdm
ICU-20568 Add Unit Usage support to Number Skeletons.
9db6be3 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 2, 2020
@hugovdm
ICU-20568 Add Unit Usage support to Number Skeletons.
3cebc27 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 2, 2020
@hugovdm
ICU-20568 Add Unit Usage support to Number Skeletons.
297d831 
PR: icu-units#33
Commit: 3cf2322
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 9, 2020
@hugovdm
ICU-20568 Implement Usage "Glue Code" and skeleton support. Tests.
be0b4c4 
CLDR-13488: Samples of intermediate source/data/misc/units.txt
PR: icu-units#5
Commit: 08132e7

Unit test improvements (the rest of PR already upstreamed).
PR: sffc#40
Commit: e92a2fc

Use namespace ::icu::units::impl for units-related code.
PR: icu-units#16
Commit: 57b35a8

Export addSingleFactorConstant in header file
PR: icu-units#17
Commit: f357b55

Fix MeasureUnit identifiers to be spec-compliant.
PR: icu-units#18
Commit: 69c0871

Cleanup: IWYU headers (with some exceptions), SigNum -> Signum
PR: icu-units#19
Commit: 1c29a6b

Test that addSingleFactorConstant knowns all unitConstants.
PR: icu-units#20
Commit: 6c0c3bb

Add Unit Usage support to Number Skeletons.
PR: icu-units#33
Commit: 3cf2322

Fix some compiler warnings
PR: icu-units#43
Commit: be11edb
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 10, 2020
@hugovdm
ICU-20568 Implement Usage "Glue Code" and skeleton support. Tests.
83878cd 
CLDR-13488: Samples of intermediate source/data/misc/units.txt
PR: icu-units#5
Commit: 08132e7

Unit test improvements (the rest of PR already upstreamed).
PR: sffc#40
Commit: e92a2fc

Use namespace ::icu::units::impl for units-related code.
PR: icu-units#16
Commit: 57b35a8

Export addSingleFactorConstant in header file
PR: icu-units#17
Commit: f357b55

Fix MeasureUnit identifiers to be spec-compliant.
PR: icu-units#18
Commit: 69c0871

Cleanup: IWYU headers (with some exceptions), SigNum -> Signum
PR: icu-units#19
Commit: 1c29a6b

Test that addSingleFactorConstant knowns all unitConstants.
PR: icu-units#20
Commit: 6c0c3bb

Add Unit Usage support to Number Skeletons.
PR: icu-units#33
Commit: 3cf2322

Fix some compiler warnings
PR: icu-units#43
Commit: be11edb
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 10, 2020
@hugovdm
ICU-20568 Implement Usage "Glue Code" and skeleton support. Tests.
d2455fc 
CLDR-13488: Samples of intermediate source/data/misc/units.txt
PR: icu-units#5
Commit: 08132e7

Unit test improvements (the rest of PR already upstreamed).
PR: sffc#40
Commit: e92a2fc

Use namespace ::icu::units::impl for units-related code.
PR: icu-units#16
Commit: 57b35a8

Export addSingleFactorConstant in header file
PR: icu-units#17
Commit: f357b55

Fix MeasureUnit identifiers to be spec-compliant.
PR: icu-units#18
Commit: 69c0871

Cleanup: IWYU headers (with some exceptions), SigNum -> Signum
PR: icu-units#19
Commit: 1c29a6b

Test that addSingleFactorConstant knowns all unitConstants.
PR: icu-units#20
Commit: 6c0c3bb

Add Unit Usage support to Number Skeletons.
PR: icu-units#33
Commit: 3cf2322

Fix some compiler warnings
PR: icu-units#43
Commit: be11edb
hugovdm added a commit to unicode-org/icu that referenced this pull request Sep 10, 2020
@hugovdm
ICU-20568 Implement Usage "Glue Code" and skeleton support. Tests.
7ed2a2d 
CLDR-13488: Samples of intermediate source/data/misc/units.txt
PR: icu-units#5
Commit: 08132e7

Unit test improvements (the rest of PR already upstreamed).
PR: sffc#40
Commit: e92a2fc

Use namespace ::icu::units::impl for units-related code.
PR: icu-units#16
Commit: 57b35a8

Export addSingleFactorConstant in header file
PR: icu-units#17
Commit: f357b55

Fix MeasureUnit identifiers to be spec-compliant.
PR: icu-units#18
Commit: 69c0871

Cleanup: IWYU headers (with some exceptions), SigNum -> Signum
PR: icu-units#19
Commit: 1c29a6b

Test that addSingleFactorConstant knowns all unitConstants.
PR: icu-units#20
Commit: 6c0c3bb

Add Unit Usage support to Number Skeletons.
PR: icu-units#33
Commit: 3cf2322

Fix some compiler warnings
PR: icu-units#43
Commit: be11edb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@younies younies Awaiting requested review from younies

Assignees

@sffc sffc

Labels
None yet
Projects
None yet
Milestone
2020-Q3-m2
Development

Successfully merging this pull request may close these issues.

Implement usage skeletons
2 participants
@hugovdm @sffc