Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setEmotion is not thread safe #138

Closed
S-Dafarra opened this issue Jun 16, 2023 · 1 comment · Fixed by #139
Closed

setEmotion is not thread safe #138

S-Dafarra opened this issue Jun 16, 2023 · 1 comment · Fixed by #139
Assignees
@S-Dafarra @martinaxgloria
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix

Comments

@S-Dafarra
Copy link
Contributor

I was checking the code, and I noticed that if I call setEmotion from code repeatedly, there might be race conditions. In fact, subsequent calls to setEmotion might change the values of isTransition and command while they are being used in updateModule

cc @Nicogene @martinaxgloria
@S-Dafarra S-Dafarra mentioned this issue Jun 16, 2023
Merged
@S-Dafarra
Copy link
Contributor Author

Related PR: #139

@Nicogene Nicogene added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S-Dafarra S-Dafarra

@martinaxgloria martinaxgloria

Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added mutex in the rpc call setEmotion. S-Dafarra/ergocub-software
3 participants
@S-Dafarra @Nicogene @martinaxgloria