Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--noconfirm for apk #150

Closed
LaszloGombos opened this issue Jun 15, 2021 · 3 comments
Closed

--noconfirm for apk #150

LaszloGombos opened this issue Jun 15, 2021 · 3 comments
Labels

Comments

@LaszloGombos
Copy link

I am getting the following error.
Error: apk: Option '--noconfirm' is not supported/implemented.

Perhaps '--noconfirm' should not need to be passed on to apk

@LaszloGombos LaszloGombos changed the title noconfirm option for apk backend noconfirm for apk Jun 15, 2021
@LaszloGombos LaszloGombos changed the title noconfirm for apk --noconfirm for apk Jun 15, 2021
@icy
Copy link
Owner

icy commented Jun 16, 2021

Thanks @LaszloGombos for the report.

If apk doesn't have that option, we can update this function to avoid that error message:

_translate_noconfirm() {
. I will need to confirm this. I come across this thread https://unix.stackexchange.com/a/565076, which is positive.

@cuonglm What do you think?

@cuonglm
Copy link
Collaborator

cuonglm commented Jun 16, 2021

@icy I think it's safe to return "" for alpine, as it runs non-interactive by default.

@icy
Copy link
Owner

icy commented Jun 17, 2021

@LaszloGombos @cuonglm I've raised new PR (#151). Please have a quick look. I will get it merged and released in the next minor verion. Thanks

@icy icy added the PR ready label Jun 17, 2021
@icy icy closed this as completed in 62030ca Jun 18, 2021
icy added a commit that referenced this issue Jun 18, 2021
lib/apk: silently ignore --no-confirm option (fix #150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants