Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more 9 0 delete behaviour #39

Merged
merged 3 commits into from Dec 21, 2020

Conversation

mipmip
Copy link
Contributor

@mipmip mipmip commented Dec 21, 2020

I think I got them all now.

$ grep delete src -r | grep JSON| grep -v Bool | grep -v "#"

src/gitlab/client/merge_request.cr:      def delete_merge_request(project_id : Int32, merge_request_id : Int32) : JSON::Any
src/gitlab/client/branch.cr:      def delete_branch(project_id : Int32, branch : String) : JSON::Any
src/gitlab/client/note.cr:      def delete_issue_note(project_id : Int32, issue_id : Int32, note_id : Int32) : JSON::Any
src/gitlab/client/note.cr:      def delete_snippet_note(project_id : Int32, snippet_id : Int32, note_id : Int32) : JSON::Any
src/gitlab/client/note.cr:      def delete_merge_request_note(project_id : Int32, merge_request_id : Int32, note_id : Int32) : JSON::Any
src/gitlab/client/project.cr:      def project_delete_custom_attribute(project_id : Int32, key : String) : JSON::Any
src/gitlab/client/issue.cr:      def delete_issue(project_id : Int32, issue_id : Int32) : JSON::Any
src/gitlab/client/group.cr:      def delete_group(group_id : Int32) : JSON::Any
src/gitlab/client/group.cr:      def group_delete_custom_attribute(group_id : Int32, key : String) : JSON::Any
src/gitlab/client/label.cr:      def delete_label(project_id : Int32, name : String) : JSON::Any

Copy link
Owner

@icyleaf icyleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works!

@icyleaf icyleaf merged commit 98ad000 into icyleaf:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants