Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: no overload matches 'String#*' with type (Float64 | Int32) #23

Closed
drujensen opened this issue Oct 3, 2019 · 5 comments
Closed

Comments

@drujensen
Copy link

getting a compilation error using Markd.to_html(markdown)

In lib/markd/src/markd/parsers/inline.cr:460:26

 460 | "\u{2014}" * em_count + "\u{2013}" * en_count
                  ^
Error: no overload matches 'String#*' with type (Float64 | Int32)

Overloads are:
 - String#*(times : Int)
Couldn't find overloads for these types:
 - String#*(times : Float64)

shards.yml

  markd:
    github: icyleaf/markd
    version: 0.1.2

If I change to "\u{2014}" * em_count.to_i + "\u{2013}" * en_count.to_i then it compiles and seems to work.

@elorest
Copy link

elorest commented Oct 6, 2019

I fixed this on my branch and then noticed it's already been fixed on master.

In Crystal 0.31 3/2 => 1.5

I don't see that in the breaking change list...

Apparently 3//2 => 1 though.

crystal-lang/crystal#8120

@elorest
Copy link

elorest commented Oct 6, 2019

@icyleaf Is master stable enough to be released as 0.2.0?

@icyleaf
Copy link
Owner

icyleaf commented Oct 6, 2019

I'm on vacation now, you can use master branch.

@icyleaf
Copy link
Owner

icyleaf commented Oct 8, 2019

Close for no response, feel free to file new issue or reopen.

@icyleaf icyleaf closed this as completed Oct 8, 2019
@drujensen
Copy link
Author

@icyleaf Thanks for releasing a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants