Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git submodule/subtree for Swagger UI? #6

Closed
j8r opened this issue Feb 12, 2020 · 4 comments
Closed

Use git submodule/subtree for Swagger UI? #6

j8r opened this issue Feb 12, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@j8r
Copy link
Contributor

j8r commented Feb 12, 2020

Swagger UI is an entirely other project than this Crystal onel.
It would be better to use git module/subtree to easily update the files, instead of vendoring the JS/CSS files. It would also keep the history.

In my opinion, the whole Swagger HTTP server can even be an new Crystal project, based on this shard (but I agree it can be practical to have it here).

@j8r
Copy link
Contributor Author

j8r commented Feb 25, 2020

The "damage" is done, having this assets in this repos make it weight a lot more that only Crystal source code.

In fact @icyleaf , it isn't even needed to have them: we can use the resources from https://petstore.swagger.io/ like https://petstore.swagger.io/swagger-ui-bundle.js and https://petstore.swagger.io/swagger-ui.css

@icyleaf
Copy link
Owner

icyleaf commented Feb 25, 2020

I am working on it by using jsdelivr cdn source.

@j8r
Copy link
Contributor Author

j8r commented Feb 25, 2020

@icyleaf I just noticied there is an official unpkg available: https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/installation.md#unpkg

@icyleaf
Copy link
Owner

icyleaf commented Feb 25, 2020

jsDelivr has global CDN networks include China.

@icyleaf icyleaf added the enhancement New feature or request label Feb 25, 2020
@icyleaf icyleaf closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants