Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unencrypted, unzipped extracted file download not working #431

Closed
mmguero opened this issue Feb 26, 2024 · 0 comments
Closed

unencrypted, unzipped extracted file download not working #431

mmguero opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working carving Relating to carving (extraction) of files from traffic and the scanning of those files regression It worked at one point... UI Relating to general UI experience
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Feb 26, 2024

in extracted_files_http_server.py this is returning:

file-monitor-1        | ----------------------------------------
file-monitor-1        | Exception occurred during processing of request from ('192.168.208.20', 55772)
file-monitor-1        | TypeError: stat: path should be string, bytes, os.PathLike or integer, not tuple
file-monitor-1        | ----------------------------------------
nginx-proxy-1         | 192.168.208.1 - - [26/Feb/2024:16:35:15 +0000] "GET /extracted-files/quarantine/HTTP-F2W7i52RdjnOAghHWe-CeVfOI3Dx6XXbQuPa9-20240226001149.exe HTTP/1.1" 502 157 "https://training.malcolm.fyi/extracted-files/quarantine/" "Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
nginx-proxy-1         | 2024/02/26 16:35:15 [error] 94#94: *650 upstream prematurely closed connection while reading response header from upstream, client: 192.168.208.1, server: , request: "GET /extracted-files/quarantine/HTTP-F2W7i52RdjnOAghHWe-CeVfOI3Dx6XXbQuPa9-20240226001149.exe HTTP/1.1", upstream: "http://192.168.208.9:8440/quarantine/HTTP-F2W7i52RdjnOAghHWe-CeVfOI3Dx6XXbQuPa9-20240226001149.exe", host: "training.malcolm.fyi", referrer: "https://training.malcolm.fyi/extracted-files/quarantine/"

Zipped, encrypted, etc. seem to work fine. Honestly let's just handle it here like we've handled the other ones rather than just passing it up to the parent do_GET.

@mmguero mmguero added bug Something isn't working carving Relating to carving (extraction) of files from traffic and the scanning of those files regression It worked at one point... UI Relating to general UI experience labels Feb 26, 2024
@mmguero mmguero added this to the v24.03.0 milestone Feb 26, 2024
@mmguero mmguero assigned mmguero and unassigned mmguero Feb 26, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Feb 26, 2024
@mmguero mmguero closed this as completed Feb 26, 2024
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working carving Relating to carving (extraction) of files from traffic and the scanning of those files regression It worked at one point... UI Relating to general UI experience
Projects
Status: Released
Development

No branches or pull requests

1 participant