Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unformly increase number of results for table visualizations in Dashboards #447

Closed
mmguero opened this issue Mar 19, 2024 · 0 comments
Closed

unformly increase number of results for table visualizations in Dashboards #447

mmguero opened this issue Mar 19, 2024 · 0 comments
Assignees
@mmguero
Labels
dashboards Relating to Malcolm's OpenSearch Dashboards interface enhancement New feature or request
Milestone
v24.03.1

Comments

@mmguero
Copy link
Collaborator

mmguero commented Mar 19, 2024 •
edited
Loading

An analyst in the field noted that table visualizations in Dashboards are not always consistent in the number of results that are shown: some show top 20, some show top 100, etc.

We should make this consistent by:

  • setting the size parameter for these tables to something consistent (I'm going to choose 100)
    • using ripgrep to find them: rg -o '\\"table\\".*?\\"params\\":\{.*?\\"size\\":\d+' ./dashboards/dashboards/
  • making sure otherBucket is set to true to indicate when there are more than will fit in the top n results
@mmguero mmguero added enhancement New feature or request dashboards Relating to Malcolm's OpenSearch Dashboards interface labels Mar 19, 2024
@mmguero mmguero added this to the v24.03.1 milestone Mar 19, 2024
@mmguero mmguero self-assigned this Mar 19, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Mar 19, 2024
@mmguero
uniformly increase number of results for table visualizations in Dash…
12f4802 
…boards (idaholab#447)

An analyst in the field noted that table visualizations in Dashboards are not always consistent in the number of results that are shown: some show top 20, some show top 100, etc.

We should make this consistent by:

* setting the `size` parameter for these tables to something consistent (I'm going to choose **100**)
  - using ripgrep to find them: `rg -o '\\"table\\".*?\\"params\\":\{.*?\\"size\\":\d+' ./dashboards/dashboards/`
* making sure `otherBucket` is set to `true` to indicate when there are more than will fit in the top n results
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Mar 19, 2024
@mmguero
Revert "uniformly increase number of results for table visualizations…
ee277a9 
… in Dashboards (idaholab#447)"

This reverts commit 12f4802.
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Mar 19, 2024
@mmguero
idaholab#447, make sure otherBuckets is set to true for all tables
b748390
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Mar 19, 2024
@mmguero
idaholab#447, set size:100 for dashboards table
78c7b6d
@mmguero mmguero closed this as completed Mar 20, 2024
@mmguero mmguero added CISA and removed CISA labels Mar 21, 2024
This was referenced Mar 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
dashboards Relating to Malcolm's OpenSearch Dashboards interface enhancement New feature or request
Projects
Malcolm
Status: Released
Milestone
v24.03.1
Development

No branches or pull requests
1 participant
@mmguero