Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle invalid URLs better (with a 404 instead of a 500) #461

Closed
mmguero opened this issue Apr 22, 2024 · 1 comment
Closed

handle invalid URLs better (with a 404 instead of a 500) #461

mmguero opened this issue Apr 22, 2024 · 1 comment
Assignees
@mmguero
Labels
bug Something isn't working nginx Relating to Malcolm's use of nginx UI Relating to general UI experience
Milestone
v24.05.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Apr 22, 2024

Today, if I go to an invalid URL (e.g., https://localhost/whatever) you'll get an HTTP error code 500 instead. We should update the nginx.conf to default to a nice-looking 404 page (maybe part of the landing page, or could be part of the documentation) instead.
@mmguero mmguero added bug Something isn't working nginx Relating to Malcolm's use of nginx labels Apr 22, 2024
@mmguero mmguero added this to the z.staging milestone Apr 22, 2024
@mmguero mmguero added the UI Relating to general UI experience label Apr 22, 2024
@mmguero mmguero modified the milestones: z.staging, v24.05.0 Apr 29, 2024
@mmguero mmguero self-assigned this May 20, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue May 20, 2024
@mmguero
idaholab#461, more beautiful 404 and 502 error pages and handle 'not …
efc59c0 
…found' correctly as a 404
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue May 20, 2024
@mmguero
idaholab#461, more beautiful 404 and 502 error pages and handle 'not …
39f31a9 
…found' correctly as a 404
@mmguero
Copy link
Collaborator Author

mmguero commented May 20, 2024

Image

@mmguero mmguero closed this as completed May 21, 2024
This was referenced May 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
bug Something isn't working nginx Relating to Malcolm's use of nginx UI Relating to general UI experience
Projects
Malcolm
Status: Released
Milestone
v24.05.0
Development

No branches or pull requests
1 participant
@mmguero