Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FV: add support for cross-diffusion terms for non-othogonal meshes #15063

Closed
rwcarlsen opened this issue Apr 14, 2020 · 0 comments · Fixed by #15825
Closed

FV: add support for cross-diffusion terms for non-othogonal meshes #15063

rwcarlsen opened this issue Apr 14, 2020 · 0 comments · Fixed by #15825
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@rwcarlsen
Copy link
Contributor

Reason

Non-orthogonal meshes cause distortion in FV diffusion terms unless you calculate special correction factors. Implementing this will improve accuracy of FV results for unstructured (non-orthogonal) meshes.

Design

The correction factors only change when the mesh changes - so they can be computed+cached up front and only updated when the mesh moves. These correction factors should probably be stored and accessed via the face info objects for their respective faces.

Impact

This should not affect existing APIs - it will just increase the range of scenarios where FV gives good solution accuracy/correctness.

@rwcarlsen rwcarlsen added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Apr 14, 2020
FY 21 NEAMS TH Pronghorn automation moved this from To do to Done Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Development

Successfully merging a pull request may close this issue.

2 participants