Add weight functions #21963
Merged
Add weight functions #21963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwspenc
previously requested changes
Aug 29, 2022
|
Job Documentation on 528bbfc wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on 528bbfc wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
@bwspenc the failure is in an unrelated test in the "parallel sweep" (different from "parallel sweep (evens)" and "parallel sweep (odds)") recipe that I should not have enabled according to @loganharbour . |
loganharbour
approved these changes
Aug 30, 2022
loganharbour
dismissed
bwspenc’s stale review
Request for uniqueness addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21960
I'm still working on debugging the hang on 8 procs.