Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a mesh generator which creates an overlaying mesh over the given mesh #23513

Merged
merged 15 commits into from Jan 31, 2024

Conversation

MengnanLi91
Copy link
Contributor

@MengnanLi91 MengnanLi91 commented Feb 22, 2023

This PR #23513 built a new mesh generator that can generate an overlay mesh with the given mesh block.

Reason

This OverlayMeshGenerator will help meshing the gap between different mesh blocks so that we can do ray tracing in the gap region with relatively low cost. This capability is a part of the efforts to model radiative heat transfer in the gap regions between mesh blocks.

Design

The overlay mesh uses DistributedRectilinearMeshGenerator(DistributedRectilinearMeshGenerator.md) as sub-generator. The generate() method is overloaded and use MeshTools::Modification::scale and MeshTools::Modification::translate to overlay the new mesh with the input mesh. The input parameters for DistributedRectilinearMeshGenerator are all available for OverlayMeshGenerator. The required input parameters of OverlayMeshGenerator are dim (the dimension of the domain) and input (the base mesh we want to overlay).

Impact

This OverlayMeshGenerator will help meshing the gap between mesh blocks. This capability is a part of the efforts to enable ray tracing and radiative heat transfer in the gap region.

MengnanLi91 added a commit to MengnanLi91/moose that referenced this pull request Feb 22, 2023
@MengnanLi91 MengnanLi91 force-pushed the overlay_mesh_generator branch 2 times, most recently from 5150b82 to 8ebe80e Compare February 22, 2023 16:59
MengnanLi91 added a commit to MengnanLi91/moose that referenced this pull request Feb 22, 2023
@moosebuild
Copy link
Contributor

moosebuild commented Feb 22, 2023

Job Documentation on 53edc62 wanted to post the following:

View the site here

This comment will be updated on new commits.

@MengnanLi91
Copy link
Contributor Author

@loganharbour Could you add this PR to your review list as well? Big Thanks! :)

@moosebuild
Copy link
Contributor

moosebuild commented Feb 22, 2023

Job Coverage on 53edc62 wanted to post the following:

Framework coverage

796cb8 #23513 53edc6
Total Total +/- New
Rate 85.24% 85.24% +0.00% 88.89%
Hits 99138 99172 +34 32
Misses 17166 17168 +2 4

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 88.89% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job External app tests on 14be48c : invalidated by @MengnanLi91

@moosebuild
Copy link
Contributor

Job App documentation on 14be48c : invalidated by @MengnanLi91

@moosebuild
Copy link
Contributor

Job Conda (Ubuntu) on 935aa7b : invalidated by @MengnanLi91

@moosebuild
Copy link
Contributor

Job Conda (ARM Mac) on a88125a : invalidated by @MengnanLi91

@GiudGiud
Copy link
Contributor

GiudGiud commented Mar 1, 2023

I m excited for this.
Meshing by overlaying rectilinear meshes and just cutting parts out is not as difficult conceptually to do as just meshing arbitrary volumes lining up with boundaries exactly and it s a viable approach for many problems.

@MengnanLi91 MengnanLi91 reopened this Jan 25, 2024
@github-actions github-actions bot removed the stale PRs that have reached or exceeded 90 days with no activity label Jan 26, 2024
MengnanLi91 and others added 14 commits January 29, 2024 14:42
Update MeshGenerator.C
Co-Authored-By: Logan Harbour <loganhharbour@gmail.com>
…ibuted mesh

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
Update OverlappingMeshGenerator.md

Update OverlayMeshGenerator.C
Add test case and doco

Update MeshGenerator.C

Update tests

Update MeshGenerator.md

Add gold mesh files

Update tests

Update tests
Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
Co-Authored-By: roystgnr <2367346+roystgnr@users.noreply.github.com>

Fix typo in OverlayMeshGenerator.md
@GiudGiud
Copy link
Contributor

@roystgnr prefer to review or should I

@roystgnr
Copy link
Contributor

I'll take another pass

Copy link
Contributor

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have quibbles about wording and I think some of those header inclusions are atavisms from other files (or older versions?) but I'm not seeing any serious issues.

framework/include/meshgenerators/OverlayMeshGenerator.h Outdated Show resolved Hide resolved
framework/src/meshgenerators/OverlayMeshGenerator.C Outdated Show resolved Hide resolved
test/tests/meshgenerators/overlay_mesh_generator/tests Outdated Show resolved Hide resolved
Co-Authored-By: roystgnr <2367346+roystgnr@users.noreply.github.com>
@MengnanLi91
Copy link
Contributor Author

I have quibbles about wording and I think some of those header inclusions are atavisms from other files (or older versions?) but I'm not seeing any serious issues.

Thanks Roy!

@MengnanLi91 MengnanLi91 merged commit 6c4b5ec into idaholab:next Jan 31, 2024
47 checks passed
@MengnanLi91 MengnanLi91 deleted the overlay_mesh_generator branch January 31, 2024 00:55
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants