New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a mesh generator which creates an overlaying mesh over the given mesh #23513
Build a mesh generator which creates an overlaying mesh over the given mesh #23513
Conversation
5150b82
to
8ebe80e
Compare
e7f39da
to
611a125
Compare
Job Documentation on 53edc62 wanted to post the following: View the site here This comment will be updated on new commits. |
@loganharbour Could you add this PR to your review list as well? Big Thanks! :) |
Job Coverage on 53edc62 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
Job External app tests on 14be48c : invalidated by @MengnanLi91 |
Job App documentation on 14be48c : invalidated by @MengnanLi91 |
Job Conda (Ubuntu) on 935aa7b : invalidated by @MengnanLi91 |
Job Conda (ARM Mac) on a88125a : invalidated by @MengnanLi91 |
I m excited for this. |
a88125a
to
1d94f50
Compare
1d94f50
to
7c61698
Compare
Update MeshGenerator.C
Co-Authored-By: Logan Harbour <loganhharbour@gmail.com>
…ibuted mesh Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
Update OverlappingMeshGenerator.md Update OverlayMeshGenerator.C
Add test case and doco Update MeshGenerator.C Update tests Update MeshGenerator.md Add gold mesh files Update tests Update tests
Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> Co-Authored-By: roystgnr <2367346+roystgnr@users.noreply.github.com> Fix typo in OverlayMeshGenerator.md
405e550
to
056122a
Compare
@roystgnr prefer to review or should I |
I'll take another pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have quibbles about wording and I think some of those header inclusions are atavisms from other files (or older versions?) but I'm not seeing any serious issues.
framework/doc/content/source/meshgenerators/OverlayMeshGenerator.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: roystgnr <2367346+roystgnr@users.noreply.github.com>
Thanks Roy! |
This PR #23513 built a new mesh generator that can generate an overlay mesh with the given mesh block.
Reason
This OverlayMeshGenerator will help meshing the gap between different mesh blocks so that we can do ray tracing in the gap region with relatively low cost. This capability is a part of the efforts to model radiative heat transfer in the gap regions between mesh blocks.
Design
The overlay mesh uses DistributedRectilinearMeshGenerator(DistributedRectilinearMeshGenerator.md) as sub-generator. The generate() method is overloaded and use
MeshTools::Modification::scale
andMeshTools::Modification::translate
to overlay the new mesh with the input mesh. The input parameters for DistributedRectilinearMeshGenerator are all available for OverlayMeshGenerator. The required input parameters of OverlayMeshGenerator aredim
(the dimension of the domain) andinput
(the base mesh we want to overlay).Impact
This OverlayMeshGenerator will help meshing the gap between mesh blocks. This capability is a part of the efforts to enable ray tracing and radiative heat transfer in the gap region.