Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mortar augmented lagrange #24349

Merged
merged 42 commits into from Aug 24, 2023
Merged

Mortar augmented lagrange #24349

merged 42 commits into from Aug 24, 2023

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented May 12, 2023 •
edited by recuero

Rewrite penalty mortar formulation using Simo's paper, implement augmented Lagrange for normal contatct.

Refs #24168

@dschwen dschwen marked this pull request as draft May 12, 2023 22:28
@dschwen dschwen requested a review from recuero May 12, 2023 22:30
@dschwen dschwen force-pushed the mortar_augmented_lagrange branch 4 times, most recently from 7d637de to 62e0907 Compare May 14, 2023 02:08
@moosebuild
Copy link
Contributor

moosebuild commented May 14, 2023 •
edited

Job Documentation on 4c3b716 wanted to post the following:

View the site here

This comment will be updated on new commits.

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch from 62e0907 to 32ae4ee Compare May 14, 2023 23:52
@dschwen
Copy link
Member Author

dschwen commented May 15, 2023 •
edited 

contact/test:pdass_problems.cylinder_friction_penalty

Is the only test that needs to be regolded.

However

test:3d-mortar-contact.frictional-mortar-3d-penalty

Now fails to converge :-o

@dschwen
Copy link
Member Author

dschwen commented May 15, 2023 •
edited 

test:3d-mortar-contact.frictional-mortar-3d-penalty

Now fails to converge :-o

accumulated_slip_one             rel diff:  4.5256383e-05 ~ 4.8240713e+228 = 1.00000e+00

ha, looks like something is uninitialized...

Update: This is now a consistent exodiff.

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch from 30a6a5c to d999271 Compare May 15, 2023 04:59
@dschwen dschwen force-pushed the mortar_augmented_lagrange branch from d999271 to 8ec7269 Compare May 16, 2023 01:41
@moosebuild
Copy link
Contributor

moosebuild commented May 16, 2023 •
edited

Job Coverage on 4c3b716 wanted to post the following:

Framework coverage

9b425d #24349 4c3b71
Total Total +/- New
Rate 85.63% 85.63% +0.00% 100.00%
Hits 90146 90152 +6 6
Misses 15128 15128 - 0

Diff coverage report

Full coverage report

Modules coverage

Contact

9b425d #24349 4c3b71
Total Total +/- New
Rate 90.12% 89.86% -0.26% 89.74%
Hits 3696 3830 +134 315
Misses 405 432 +27 36

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • contact new line coverage rate 89.74% is less than the suggested 90.0%

This comment will be updated on new commits.

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch from 8a9049b to 2fab312 Compare May 16, 2023 04:37
@dschwen
Copy link
Member Author

dschwen commented May 16, 2023

Ugh, regolding the cylinder test I noticed that the result for a serial run are different (of course we're not testing that)

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch from 2fab312 to 4314bae Compare May 17, 2023 23:37
@dschwen dschwen force-pushed the mortar_augmented_lagrange branch 3 times, most recently from 4612e3c to 1e066b0 Compare May 19, 2023 20:40
@moosebuild
Copy link
Contributor

Job Newer gcc on 1e066b0 : invalidated by @dschwen

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch 2 times, most recently from b33cfbc to 7c4292f Compare May 21, 2023 18:14
@moosebuild
Copy link
Contributor

Job Python 3.8 on 7c4292f : invalidated by @dschwen

fails repeatedly

@dschwen dschwen force-pushed the mortar_augmented_lagrange branch 2 times, most recently from aeadd24 to 5acf99a Compare August 15, 2023 22:16
@recuero recuero requested a review from bwspenc August 15, 2023 22:25
recuero
recuero previously approved these changes Aug 17, 2023
View reviewed changes
@moosebuild
Copy link
Contributor

Job Conda MOOSE (ARM Mac) on 11e7370 : invalidated by @recuero

1 similar comment
@moosebuild
Copy link
Contributor

Job Conda MOOSE (ARM Mac) on 11e7370 : invalidated by @recuero

bwspenc
bwspenc requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few minor things that I think should still be addressed. As we discussed, by far the most important one is getting rid of the default tolerances.

modules/contact/src/auxkernels/PenaltyMortarUserObjectAux.C Show resolved Hide resolved
modules/contact/src/postprocessors/NumAugmentedLagrangeIterations.C Show resolved Hide resolved
modules/contact/include/userobjects/WeightedGapUserObject.h Show resolved Hide resolved
modules/contact/src/userobjects/PenaltyFrictionUserObject.C Show resolved Hide resolved
modules/contact/src/userobjects/PenaltyFrictionUserObject.C Outdated Show resolved Hide resolved
modules/contact/src/userobjects/PenaltyWeightedGapUserObject.C Show resolved Hide resolved
modules/contact/src/userobjects/PenaltyWeightedGapUserObject.C Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

Job Conda MOOSE (ARM Mac) on c9be92e : invalidated by @recuero

bwspenc
bwspenc approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing my issues.

Follow-on items that we shouldn't forget:

  1. Rename those "force" variables to "pressure"
  2. Change the default value of "penalty_multiplier" to 100 in the Contact action

@idaholab idaholab deleted a comment from bwspenc Aug 23, 2023
@idaholab idaholab deleted a comment from bwspenc Aug 23, 2023
@dschwen dschwen merged commit 47d2047 into idaholab:next Aug 24, 2023
47 of 48 checks passed
@recuero recuero mentioned this pull request Sep 5, 2023
Merged
recuero added a commit to recuero/moose that referenced this pull request Sep 5, 2023
@recuero
Address Ben's comments from idaholab#24349
f9b61c5
recuero added a commit to recuero/moose that referenced this pull request Sep 6, 2023
@recuero
Address Ben's comments from idaholab#24349
46c27f6
recuero added a commit to recuero/moose that referenced this pull request Sep 12, 2023
@recuero
Address Ben's comments from idaholab#24349
120c874
oanaoana pushed a commit to oanaoana/moose that referenced this pull request Oct 19, 2023
@dschwen @oanaoana
Parallel consistent messages (idaholab#24349)
6fa40d0
oanaoana pushed a commit to oanaoana/moose that referenced this pull request Oct 19, 2023
@dschwen @oanaoana
Improve coverage (idaholab#24349)
77f351e
oanaoana pushed a commit to oanaoana/moose that referenced this pull request Oct 19, 2023
@recuero @oanaoana
Address Ben's comments from idaholab#24349
3d39e31
oanaoana pushed a commit to oanaoana/moose that referenced this pull request Nov 7, 2023
@recuero @oanaoana
Address Ben's comments from idaholab#24349
1f6b53f
@lindsayad lindsayad mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recuero recuero recuero left review comments

@bwspenc bwspenc bwspenc approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84 jiangwen84 is a code owner

Assignees

@dschwen dschwen

@recuero recuero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dschwen @moosebuild @loganharbour @bwspenc @recuero