Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raviart-Thomas elements #26105

Merged
merged 8 commits into from Dec 4, 2023
Merged

Raviart-Thomas elements #26105

merged 8 commits into from Dec 4, 2023

Conversation

karthichockalingam
Copy link
Contributor

Reason

Design

Impact

Enables H(div) simulations using Raviart-Thomas elements.

Kind regards,
Karthik and Nuno
(cc @nmnobre)

nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add the Raviart-Thomas FE family (idaholab#26105)
1c3336c
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add H(div) helper functions and types (idaholab#26105)
1ac3ab3 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add Dirichlet bcs for the divergence of a vector field (idaholab#26105)
a2d64aa 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add DivField and GradField kernels (idaholab#26105)
daed7ed 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add coupled electrostatics test problem (idaholab#26105)
948202f 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add docs for the new FE family, bcs and kernels (idaholab#26105)
68833b8
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Apply clang-format suggestions (idaholab#26105)
1f6e33a
lindsayad
lindsayad requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution! I have reviewed the framework portion. I think @cticenhour should review the EM portion

framework/include/bcs/VectorDivPenaltyDirichletBC.h Outdated Show resolved Hide resolved
framework/src/actions/SetAdaptivityOptionsAction.C Show resolved Hide resolved
framework/doc/content/source/bcs/VectorDivPenaltyDirichletBC.md Show resolved Hide resolved
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add the Raviart-Thomas FE family (idaholab#26105)
6b48ba2
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add H(div) helper functions and types (idaholab#26105)
39a77f6 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add Dirichlet bcs for the divergence of a vector field (idaholab#26105)
7e0fed2 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add DivField and GradField kernels (idaholab#26105)
ea97bb4 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add coupled electrostatics test problem (idaholab#26105)
e6c9c08 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add docs for the new FE family, bcs and kernels (idaholab#26105)
66985d8
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Apply clang-format suggestions (idaholab#26105)
f0f7e3c
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add the Raviart-Thomas FE family (idaholab#26105)
47a57c8
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add H(div) helper functions and types (idaholab#26105)
3f59137 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@karthichockalingam @nmnobre
Add Dirichlet bcs for the divergence of a vector field (idaholab#26105)
9b3f932 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add DivField and GradField kernels (idaholab#26105)
e74bfad 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre @karthichockalingam
Add coupled electrostatics test problem (idaholab#26105)
31bce93 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add docs for the new FE family, bcs and kernels (idaholab#26105)
96e9453
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Apply clang-format suggestions (idaholab#26105)
7ff486d
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 20, 2023
@nmnobre
Add missing override keyword in bcs headers (idaholab#26105)
6e121d9
@nmnobre @karthichockalingam
Add DivField and GradField kernels (idaholab#26105)
d810382 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre @karthichockalingam
Add coupled electrostatics test problem (idaholab#26105)
41f6a0a 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Add docs for the new FE family, bcs and kernels (idaholab#26105)
9786bef
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Apply clang-format suggestions (idaholab#26105)
5517ee6
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Help the user to choose a vector penalty bc (idaholab#26105)
2efbbd3
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre @karthichockalingam
Add coupled electrostatics test problem (idaholab#26105)
bfd6609 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Add docs for the new FE family, bcs and kernels (idaholab#26105)
b4ac193
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Apply clang-format suggestions (idaholab#26105)
db8ec51
nmnobre added a commit to farscape-project/moose that referenced this pull request Nov 30, 2023
@nmnobre
Help the user to choose a vector penalty bc (idaholab#26105)
bd0acf7
lindsayad
lindsayad approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/tests/kernels/vector_fe/coupled_electrostatics.i Show resolved Hide resolved
cticenhour
cticenhour approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks @nmnobre!

@lindsayad lindsayad merged commit 08f703b into idaholab:next Dec 4, 2023
44 checks passed
@lindsayad
Copy link
Member

Thanks guys!

chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @chaibhave
Add the Raviart-Thomas FE family (idaholab#26105)
7ef654e
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@karthichockalingam @nmnobre @chaibhave
Add H(div) helper functions and types (idaholab#26105)
0bdd94e 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@karthichockalingam @nmnobre @chaibhave
Add Dirichlet bcs for the divergence of a vector field (idaholab#26105)
f246bc4 
Co-authored-by: Nuno Nobre <nuno.nobre@stfc.ac.uk>
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @karthichockalingam @chaibhave
Add DivField and GradField kernels (idaholab#26105)
6b2bbf5 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @karthichockalingam @chaibhave
Add coupled electrostatics test problem (idaholab#26105)
b26c66d 
Co-authored-by: karthichockalingam <karthikeyan.chockalingam@stfc.ac.uk>
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @chaibhave
Add docs for the new FE family, bcs and kernels (idaholab#26105)
27114ca
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @chaibhave
Apply clang-format suggestions (idaholab#26105)
b6e64e1
chaibhave pushed a commit to chaibhave/moose that referenced this pull request Dec 6, 2023
@nmnobre @chaibhave
Help the user to choose a vector penalty bc (idaholab#26105)
7e0b803
@nmnobre nmnobre deleted the rt branch February 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roystgnr roystgnr roystgnr approved these changes

@nmnobre nmnobre nmnobre left review comments

@lindsayad lindsayad lindsayad approved these changes

@cticenhour cticenhour cticenhour approved these changes

Assignees

@lindsayad lindsayad

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@karthichockalingam @moosebuild @lindsayad @nmnobre @cticenhour @roystgnr