Add application block #26474

MengnanLi91 · 2024-01-04T00:45:57Z

This PR add a [Application] block in the input file and parse the application type. The MOOSE app will only be created if the app type in the input file is consistent with the registered MOOSE app. Related issue is mentioned in #23741

Design

A new [Application] block is added in the input file and parsed before the MOOSE app is created. The [Application] block is implemented via Action with a parameter named 'type'.

Impact

It will be more explicit which app the input file belongs to and very useful for multi-app simulations

modules/combined/test/tests/application_block_check/parent.i

moosebuild · 2024-01-10T21:02:31Z

Job Documentation on 69f4fbc wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2024-01-16T03:19:15Z

Job Coverage on 69f4fbc wanted to post the following:

Framework coverage

	19aa8b	#26474 69f4fb
	Total	Total	+/-	New
Rate	85.21%	85.22%	+0.00%	93.55%
Hits	99627	99683	+56	58
Misses	17291	17294	+3	4

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild · 2024-01-16T16:27:08Z

Job OpenMPI on 258b7f3 : invalidated by @MengnanLi91

richards/test:rogers_stallybrass_clements.rsc02 seems irrelevant failure

cticenhour

After some struggle, I found the issue. I always forget this, but test spec detail fields get rendered just like any other text. This means the [Application] syntax gets rendered as a link, but fails because it's an invalid one.

See the suggested changes below!

test/tests/multiapps/application_block_multiapps/tests

MengnanLi91 · 2024-01-22T04:23:33Z

Griffin needs a patch to adapt the changes in this PR. Besides that, the PR is ready for review

GiudGiud

mostly cosmetics

framework/include/actions/CreateApplicationBlockAction.h

framework/src/actions/CreateApplicationBlockAction.C

test/tests/multiapps/application_block_multiapps/tests

modules/combined/test/tests/application_block_check/tests

modules/combined/test/src/base/CombinedTestApp.C

framework/src/multiapps/MultiApp.C

framework/include/actions/CreateApplicationBlockAction.h

framework/include/base/MooseApp.h

framework/include/parser/Parser.h

framework/include/actions/CreateApplicationBlockAction.h

framework/src/multiapps/MultiApp.C

framework/doc/content/source/actions/CreateApplicationBlockAction.md

framework/doc/content/syntax/Application/index.md

framework/include/parser/Parser.h

framework/src/base/AppFactory.C

framework/include/actions/CreateApplicationBlockAction.h

framework/src/multiapps/MultiApp.C

modules/combined/test/tests/application_block_check/tests

moosebuild · 2024-01-29T21:24:55Z

Job Precheck on 4c2d0ea wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/26474/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 796cb8aa68a15d61eb82eb353bb6582b01c6634f

unit/src/MooseServerTest.C

Co-Authored-By: Casey Icenhour <casey.icenhour@inl.gov>

Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> Address review: cosmetic changes Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> Co-Authored-By: Logan Harbour <loganhharbour@gmail.com>

This means we shouldn't have to break griffin

cticenhour

Please add an entry on this to the news template for February in a follow-up PR!

framework/doc/content/source/actions/CreateApplicationBlockAction.md

GiudGiud

just that doco line

Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>

moosebuild · 2024-02-06T00:51:06Z

Job OpenMPI on 69f4fbc : invalidated by @MengnanLi91

postprocessors/interface_diffusive_flux.average/fe FAILED (ERRMSG)

GiudGiud reviewed Jan 6, 2024

View reviewed changes

modules/combined/test/tests/application_block_check/parent.i Outdated Show resolved Hide resolved

MengnanLi91 self-assigned this Jan 9, 2024

MengnanLi91 force-pushed the Add_application_block branch from ae4b2a4 to c1a7f49 Compare January 10, 2024 19:07

MengnanLi91 force-pushed the Add_application_block branch from c1a7f49 to a19c3bd Compare January 15, 2024 21:25

MengnanLi91 added a commit to MengnanLi91/moose that referenced this pull request Jan 15, 2024

Add application block and parse app type idaholab#26474

01916d3

MengnanLi91 force-pushed the Add_application_block branch from a19c3bd to 21b74c8 Compare January 15, 2024 21:40

cticenhour requested changes Jan 18, 2024

View reviewed changes

test/tests/multiapps/application_block_multiapps/tests Outdated Show resolved Hide resolved

test/tests/multiapps/application_block_multiapps/tests Outdated Show resolved Hide resolved

MengnanLi91 force-pushed the Add_application_block branch from a1a86c5 to 6143946 Compare January 20, 2024 18:49

MengnanLi91 marked this pull request as ready for review January 22, 2024 04:21

MengnanLi91 requested review from lindsayad and roystgnr as code owners January 22, 2024 04:21

GiudGiud requested changes Jan 23, 2024

View reviewed changes

MengnanLi91 requested a review from GiudGiud January 24, 2024 22:00

loganharbour requested changes Jan 25, 2024

View reviewed changes

GiudGiud reviewed Jan 29, 2024

View reviewed changes

MengnanLi91 force-pushed the Add_application_block branch 2 times, most recently from 28dcbd5 to d9357e1 Compare January 29, 2024 21:56

MengnanLi91 added a commit to MengnanLi91/moose that referenced this pull request Jan 29, 2024

Add application block and parse app type idaholab#26474

951701c

MengnanLi91 requested review from GiudGiud and loganharbour January 30, 2024 00:45

GiudGiud reviewed Jan 30, 2024

View reviewed changes

unit/src/MooseServerTest.C Outdated Show resolved Hide resolved

MengnanLi91 added 4 commits February 3, 2024 08:35

Add application block and parse app type idaholab#26474

7df40d8

Add test cases, documentation and clean up

01c9445

Adapt new changes in Parser

0fcb132

Remove debug cout line from MooseMain.C

34c7fcb

MengnanLi91 and others added 6 commits February 3, 2024 08:35

Modify MOOSE doc for failure tests

0c21f6e

Add Application block to yaml file

ebd9551

[Application] syntax error in test file detail line

b657fff

Co-Authored-By: Casey Icenhour <casey.icenhour@inl.gov>

Get app type directly from parser

2c01486

Address review: documentation improvements

59c197b

Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> Address review: cosmetic changes Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com> Co-Authored-By: Logan Harbour <loganhharbour@gmail.com>

Clean format for precheck

c7637ab

loganharbour force-pushed the Add_application_block branch from a476a53 to c7637ab Compare February 3, 2024 15:38

Remove redundant MooseApp::getAppType()

5402bce

This means we shouldn't have to break griffin

moosebuild added the PR: Failed but allowed label Feb 3, 2024

loganharbour approved these changes Feb 5, 2024

View reviewed changes

MengnanLi91 requested review from GiudGiud and cticenhour February 5, 2024 16:48

cticenhour approved these changes Feb 5, 2024

View reviewed changes

GiudGiud reviewed Feb 5, 2024

View reviewed changes

framework/doc/content/source/actions/CreateApplicationBlockAction.md Outdated Show resolved Hide resolved

GiudGiud reviewed Feb 5, 2024

View reviewed changes

moosebuild removed the PR: Failed but allowed label Feb 5, 2024

MengnanLi91 requested a review from GiudGiud February 5, 2024 22:29

GiudGiud approved these changes Feb 5, 2024

View reviewed changes

Address review: improve CreateApplicationBlockAction doc

69f4fbc

Co-Authored-By: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>

MengnanLi91 force-pushed the Add_application_block branch from 5a4b823 to 69f4fbc Compare February 5, 2024 23:27

loganharbour approved these changes Feb 6, 2024

View reviewed changes

moosebuild added the PR: Failed but allowed label Feb 6, 2024

MengnanLi91 merged commit 096ce97 into idaholab:next Feb 6, 2024
49 checks passed

schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this pull request Mar 12, 2024

Add application block and parse app type idaholab#26474

cbd37c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add application block #26474

Add application block #26474

MengnanLi91 commented Jan 4, 2024

moosebuild commented Jan 10, 2024 •

edited

moosebuild commented Jan 16, 2024 •

edited

moosebuild commented Jan 16, 2024

cticenhour left a comment

MengnanLi91 commented Jan 22, 2024

GiudGiud left a comment

moosebuild commented Jan 29, 2024

cticenhour left a comment

GiudGiud left a comment

moosebuild commented Feb 6, 2024

Add application block #26474

Add application block #26474

Conversation

MengnanLi91 commented Jan 4, 2024

Design

Impact

moosebuild commented Jan 10, 2024 • edited

moosebuild commented Jan 16, 2024 • edited

Framework coverage

Modules coverage

Full coverage reports

moosebuild commented Jan 16, 2024

cticenhour left a comment

Choose a reason for hiding this comment

MengnanLi91 commented Jan 22, 2024

GiudGiud left a comment

Choose a reason for hiding this comment

moosebuild commented Jan 29, 2024

cticenhour left a comment

Choose a reason for hiding this comment

GiudGiud left a comment

Choose a reason for hiding this comment

moosebuild commented Feb 6, 2024

moosebuild commented Jan 10, 2024 •

edited

moosebuild commented Jan 16, 2024 •

edited