Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two map variables in MooseMesh are not rebuilt in recovery mode #27696

Closed
YaqiWang opened this issue May 23, 2024 · 0 comments · Fixed by #27697
Closed

Two map variables in MooseMesh are not rebuilt in recovery mode #27696

YaqiWang opened this issue May 23, 2024 · 0 comments · Fixed by #27697
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

Motivation

These two maps

  std::unordered_map<std::pair<const Elem *, unsigned short int>, const Elem *>
      _higher_d_elem_side_to_lower_d_elem;
  std::unordered_map<const Elem *, unsigned short int> _lower_d_elem_to_higher_d_elem_side;

are not rebuilt in the recovery mode. It will cause functions relying on the two maps not working properly.

Design

In MooseMesh::init() on the code path with recovery, we need to rebuilt the two maps.

Impact

Currently we have not hit this issue because we do not have recovery test that calling the functions in MooseMesh relying on these two maps.

@YaqiWang YaqiWang added the T: task An enhancement to the software. label May 23, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue May 23, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue May 23, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue May 23, 2024
YaqiWang added a commit to YaqiWang/moose that referenced this issue May 23, 2024
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
2 participants