Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursion in SideSetsGeneratorBase for fixed normal comparison #27824

Open
dschwen opened this issue Jun 7, 2024 · 0 comments
Open

Avoid recursion in SideSetsGeneratorBase for fixed normal comparison #27824

dschwen opened this issue Jun 7, 2024 · 0 comments
Assignees
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Jun 7, 2024

Motivation

Recursion (or a custom stack) in this mesh generator is required to follow sides with progressively changing normals that are within tolerance of each other. It is not required for a fixed normal comparison, which should significantly improve performance for large meshes. Also there seems to be an unnecessary double loop over sides.

Design

Remove second (actually first) loop over the sides and bail early form flood for fixed normal comparison.

Impact

Improved performance, no stack overflow for large meshes.

@dschwen dschwen added the T: task An enhancement to the software. label Jun 7, 2024
@dschwen dschwen self-assigned this Jun 7, 2024
@GiudGiud GiudGiud added C: Meshing MeshGenerator system, mesh loading C: Framework labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

2 participants