Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SINGLE RUN with HDF5 crash #695

Closed
10 tasks done
waynemorrison opened this issue Jul 18, 2018 · 5 comments · Fixed by #674
Closed
10 tasks done

SINGLE RUN with HDF5 crash #695

waynemorrison opened this issue Jul 18, 2018 · 5 comments · Fixed by #674

Comments

@waynemorrison
Copy link

waynemorrison commented Jul 18, 2018


Issue Description
relap_pwr_loca_sampler.txt


What did you expect to see happen?

N/A

What did you see instead?

( 0.04 sec) SIMULATION : Message -> -- Beginning step sampleRELAP of type: SingleRun --
( 0.04 sec) STEP SINGLERUN : Message -> *** Beginning initialization ***
( 0.04 sec) STEP SINGLERUN : Message -> *** Initialization done ***
( 0.04 sec) STEP SINGLERUN : Message -> *** Beginning run ***
( 0.04 sec) Code : Message -> job "None" submitted!
( 0.06 sec) Code : Message -> Execution command submitted: /usr/local/tools/RELAP53D_INL/4.3.4/SLE12/relap/bin/relap5.x -i typpwr_PTC.i -o out~typpwr_PTC.o
Traceback (most recent call last):
File "/home/wmorrison/RAVEN_July_18/raven/framework/Driver.py", line 281, in
raven()
File "/home/wmorrison/RAVEN_July_18/raven/framework/Driver.py", line 234, in raven
simulation.run()
File "/home/wmorrison/RAVEN_July_18/raven/framework/Simulation.py", line 791, in run
stepInstance.takeAstep(stepInputDict)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Steps.py", line 312, in takeAstep
self._localTakeAstepRun(inDictionary)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Steps.py", line 462, in _localTakeAstepRun
model.collectOutput(finishedJob,output)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Models/Code.py", line 667, in collectOutput
output.addRealization(evaluation)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Databases.py", line 248, in addRealization
self.database.addGroup(rlz)
File "/home/wmorrison/RAVEN_July_18/raven/framework/h5py_interface_creator.py", line 189, in addGroup
groupName = str(rlz.get("prefix")[0] if not isinstance(rlz.get("prefix"),basestring) else rlz.get("prefix"))
TypeError: 'NoneType' object has no attribute 'getitem'

Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@mandd
Copy link
Collaborator

mandd commented Jul 19, 2018

Wayne,
does this fix your problem?
<HistorySet name="RELAPoutput"> <Input>5050101:3</Input> <Output>time, tempf_345010000, cntrlvar_23, cntrlvar_21, mflowj_335010000, p_335010000, httemp_3360001_9, httemp_3360001_16, httemp_3360002_9, httemp_3360003_9, httemp_3360004_9, httemp_3360005_9, httemp_3360006_9 </Output> <Index var="time"> tempf_345010000, cntrlvar_23, cntrlvar_21, mflowj_335010000, p_335010000, httemp_3360001_9, httemp_3360001_16, httemp_3360002_9, httemp_3360003_9, httemp_3360004_9, httemp_3360005_9, httemp_3360006_9 </Index> </HistorySet>

along with

<PointSet name="RELAPScalarOutput"> <Input>5050101:3</Input> <Output>cntrlvar_23,time</Output> <options> <pivotParameter>time</pivotParameter> <operator>max</operator> </options> </PointSet>

@waynemorrison
Copy link
Author

Hi Diego, Andrea resolved this issue -- the problem with the HDF5. Thanks!

alfoa added a commit that referenced this issue Jul 20, 2018
@alfoa alfoa mentioned this issue Jul 20, 2018
8 tasks
@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018

See PR #674

@wangcj05
Copy link
Collaborator

An email should be proposed, and the defect is only happened to the devel, not affect to the stable branch.

@wangcj05
Copy link
Collaborator

Checklist is satisfied, and an email is proposed in PR#673

wangcj05 pushed a commit that referenced this issue Jul 20, 2018
* Closes #673

* removed leftover

* added margina to crow

* added wright

* regolded tests

* addressed wangcj05 coments

* unit test

* added relative tolerance

* improved docstrings

* addressed Congjian's comments

* relaxed multivariate test

* Closes #695

* added test to test the fix

* Closes #583

* added pivotparameter test

* modified tests for new pivotparameter strategy

* modified SIngleRun for setting a default prefix

* modified gold file

* typo for the gainGrowthFactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants