Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in saveInDB step of runLS.xml case from raven_folder/doc/workshop folder #780

Closed
10 tasks done
alfoa opened this issue Sep 11, 2018 · 1 comment · Fixed by #781
Closed
10 tasks done

Error in saveInDB step of runLS.xml case from raven_folder/doc/workshop folder #780

alfoa opened this issue Sep 11, 2018 · 1 comment · Fixed by #781

Comments

@alfoa
Copy link
Collaborator

alfoa commented Sep 11, 2018


Issue Description

What did you expect to see happen?

workshop case to run successfully

What did you see instead?
Email from an user:

Hello RAVEN Users,

I'm having trouble to run the workshop case runLS available from raven_folder/doc/workshop (see attached).

For this case, 4 steps are supposed to be executed: MCRun, adaptive, plot, and saveInDB. The first three runs smoothly while the forth one produces the following error:

Traceback (most recent call last):
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Driver.py", line 281, in <module>
    raven()
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Driver.py", line 234, in raven
    simulation.run()
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Simulation.py", line 798, in run
    stepInstance.takeAstep(stepInputDict)
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Steps.py", line 312, in takeAstep
    self._localTakeAstepRun(inDictionary)
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Steps.py", line 916, in _localTakeAstepRun
    outputs[i].addRealization(rlz)
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/Databases.py", line 248, in addRealization
    self.database.addGroup(rlz)
  File "/home/av_ale/IdahoLab/RAVEN-Master_branch/framework/h5py_interface_creator.py", line 189, in addGroup
    groupName = str(rlz.get("prefix")[0] if not isinstance(rlz.get("prefix"),basestring) else rlz.get("prefix"))
TypeError: 'NoneType' object has no attribute '__getitem__'

Any idea why this happens?

Thank you in advance,
Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@alfoa alfoa self-assigned this Sep 11, 2018
alfoa added a commit that referenced this issue Sep 12, 2018
@alfoa alfoa mentioned this issue Sep 12, 2018
8 tasks
@wangcj05
Copy link
Collaborator

Email is not required, since a new PR with the workshop update is created #797, and an email will be proposal in that PR.

wangcj05 pushed a commit that referenced this issue Sep 20, 2018
* Closes  #780

* Update h5py_interface_creator.py

* Update test_adaptive_sampler.xml

* Update test_adaptive_sampler.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants