Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified interfaces to be agnostics with respect to the sampler type #181

Merged
merged 2 commits into from
May 17, 2017

Conversation

alfoa
Copy link
Collaborator

@alfoa alfoa commented May 16, 2017


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #180
Closes #35

What are the significant changes in functionality due to this change request?

Just interface


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code. All the changes have been reviewed and make the code more simple
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts). No Change
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details. Compliant
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass. Passed!
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True. No Change
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync. No Change
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done. Closes RELAP5 interface does not handle the limitsurfacesearhc #180 and CodeInterface samplers dictionary needs to be updated. #35
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added? No Change

self._samplersDictionary[samplerType] = self.dynamicEventTreeForMooseBasedApp
else:
self._samplersDictionary[samplerType] = self.pointSamplerForMooseBasedApp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top!

Copy link
Contributor

@maljovec maljovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maljovec maljovec merged commit 683d78a into devel May 17, 2017
@maljovec maljovec deleted the alfoa/codeinterfacesSamplers branch May 17, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants