Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing crow mentions #23

Merged
merged 9 commits into from
Apr 18, 2017

Conversation

joshua-cogliati-inl
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl commented Apr 4, 2017


Pull Requeset Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#12

What are the significant changes in functionality due to this change request?

This removes mentions of crow from the source code and the installation procedures.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@moosebuild
Copy link

Job Test linux:linux-gnu on 64a4039 : invalidated by @joshua-cogliati-inl

#37

@alfoa
Copy link
Collaborator

alfoa commented Apr 18, 2017

The PR modifies some documentation needed for the new GITHUB releases (e.g. CROW is not a submodule anymore, etc.). No code has been changed but just tex documents.

This PR can be accepted once the tests pass again.

@alfoa
Copy link
Collaborator

alfoa commented Apr 18, 2017

all tests passed...

Check list requirements passed.

Merging

@alfoa alfoa merged commit c48d395 into idaholab:devel Apr 18, 2017
@alfoa alfoa mentioned this pull request Jul 21, 2017
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants