Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token name in query string is hard-coded to 'access_token' #395

Closed
Kylotan opened this issue Sep 28, 2015 · 3 comments
Closed

token name in query string is hard-coded to 'access_token' #395

Kylotan opened this issue Sep 28, 2015 · 3 comments

Comments

@Kylotan
Copy link

Kylotan commented Sep 28, 2015

See: https://github.com/idan/oauthlib/blob/master/oauthlib/oauth2/rfc6749/tokens.py#L207

This prevents authentication with services such as Slack which require the token in the URI and for it to be called 'token', not 'access_token'. (https://api.slack.com/web#authentication)

@thedrow
Copy link
Collaborator

thedrow commented May 8, 2016

As far as I recall the standard does say that the URI parameter should be access_token.
We can make it configurable somehow though.
Any suggestions?

@Kylotan
Copy link
Author

Kylotan commented May 8, 2016

No, sorry. I don't understand OAuth or the library well enough to comment or suggest a solution. All I know is that I have to extract the token from the OAuth2Session and pass it back as a parameter when accessing the Slack API. If you're sure this is against the spec then maybe someone should contact Slack with reference to that spec and see if they'll change it.

@JonathanHuot
Copy link
Member

Closing the issue since the related requests/requests-oauthlib#170 is closed, too. If anybody want this in oauthlib, PR suggestions are welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants