Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding formula parser no longer possible? #320

Closed
bbroere opened this issue Jul 21, 2023 · 4 comments
Closed

Overriding formula parser no longer possible? #320

bbroere opened this issue Jul 21, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@bbroere
Copy link

bbroere commented Jul 21, 2023

I was looking at the latest release and thus far I am unable to override the formula parser used in the spreadsheet. My use case: I want to limit the functions that can be used and alter the behavior of some others. With the 0.7 releases this was possible with the formulaParser prop on the spreadsheet introduced in 61.

Is there another way I can override this in the 0.8 release?

@iddan
Copy link
Owner

iddan commented Jul 30, 2023

Hey, the underlying formula parser has changed in the last release and I wasn't sure whether to expose it. The implementation is based on https://github.com/LesterLyu/fast-formula-parser. Will it help you to access it?

@iddan iddan self-assigned this Jul 30, 2023
@iddan iddan added the enhancement New feature or request label Jul 30, 2023
@bbroere
Copy link
Author

bbroere commented Jul 31, 2023

Thanks for the response. I think I'll work on a PR making the formula parser overridable again since the implemented formula parser is nog longer maintained (see issue).

@iddan
Copy link
Owner

iddan commented Aug 1, 2023

I think the right approach would be to wrap fast-formula-parser in a way that allows passing getData.

@bbroere
Copy link
Author

bbroere commented Aug 28, 2023

See PR 329 :D

@iddan iddan closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants