Enable custom FormulaParser via props #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddan
approved these changes
Mar 23, 2020
calebmpeterson
commented
Mar 23, 2020
|
Great job. will release a version with your code. |
|
Shipped in react-spreadsheet@0.4.45 |
|
Thank you so much for the amazingly fast turn around here @iddan! All the best :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some prototyping with
react-spreadsheet(fantastic component BTW, thank you for creating it!). I'd like to be able to define custom formulas. This is possible withhot-formula-parserbut access to theformulaParserinstance is needed.Passing a
propto customize the instance used by aSpreadsheetcomponent seemed like the best solution.