Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire Selection #161

Merged
merged 58 commits into from
Apr 8, 2022
Merged

Entire Selection #161

merged 58 commits into from
Apr 8, 2022

Conversation

iddan
Copy link
Owner

@iddan iddan commented Sep 2, 2021

Resolves #103

Support selecting entire rows, columns, and tables.

Planned Changes

  • Selection will except EntireSelection in addition to the previous PointRange and null values.
  • Selection-related logic will be encapsulated and tested with entire cases as well as range and null.
  • Indicators clicks will trigger new store actions

Tasks

  • Add entire selection type to state
  • Encapsulate selection related functionality
  • Update selection methods to support entire
  • Update selected floating rectangle to support entire
  • When clicking on indicator, select entire
  • When pressing shift + arrow, modify entire selection
  • When pressing backspace delete all selected
  • When clicking indicator with shift extend range
  • Update tests
  • Copy, cut and paste for entire selections (requires testing)

Update code to treat entire selection as no selection
@coveralls
Copy link

coveralls commented Sep 2, 2021

Pull Request Test Coverage Report for Build 2115646417

  • 225 of 237 (94.94%) changed or added relevant lines in 14 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+5.5%) to 85.082%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ColumnIndicator.tsx 16 17 94.12%
src/CornerIndicator.tsx 16 17 94.12%
src/RowIndicator.tsx 16 17 94.12%
src/Spreadsheet.tsx 15 18 83.33%
src/reducer.ts 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
src/Spreadsheet.tsx 1 69.29%
src/reducer.ts 2 59.2%
Totals Coverage Status
Change from base Build 2083089060: 5.5%
Covered Lines: 905
Relevant Lines: 1034

💛 - Coveralls

@iddan iddan marked this pull request as draft September 2, 2021 11:12
@iddan iddan self-assigned this Sep 6, 2021
@iddan iddan force-pushed the master branch 2 times, most recently from a5442a2 to 3c0c51e Compare February 5, 2022 20:23
@iddan iddan marked this pull request as ready for review April 8, 2022 14:09
@iddan iddan merged commit 7a5e6a2 into master Apr 8, 2022
@iddan iddan deleted the feature/entire-selection branch April 8, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to select an entire Row/Column?
3 participants