Fix Matrix.toArray #203
Merged
Fix Matrix.toArray #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix.toArray() will now properly flatten non-square matrices to an array.
|
This is great! I haven't got to review it until now. Thank you so much |
iddan
approved these changes
Mar 3, 2022
Pull Request Test Coverage Report for Build 1814596797
💛 - Coveralls |
|
Published in 0.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
Matrix.toArrayfunction does not properly flatten non-square matrices to an array. This results in incorrect range returned by the defaultgetCellRangeValue, which in turn results in the formulas getting incorrect arguments.This PR adds the tests for the non-square matrices flattening and fixes the issue of looping the matrix columns incorrect amount of times due to the number of rows not matching the number of columns in non-square matrices.