Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lastChanged for onCellCommit coordinates #246

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

chasingmaxwell
Copy link
Contributor

@chasingmaxwell chasingmaxwell commented Jul 28, 2022

The lastChanged state property seems to contain the real coordinates to the cell which was last changed as opposed to the active property which may differ from the cell that was last changed if the user has selected a different cell.

Resolves #83.

@iddan
Copy link
Owner

iddan commented Jul 31, 2022

Thank you @chasingmaxwell!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2755007503

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.293%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Spreadsheet.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 2500751650: 0.0%
Covered Lines: 906
Relevant Lines: 1044

💛 - Coveralls

@iddan iddan merged commit 3a7a907 into iddan:master Aug 1, 2022
@iddan
Copy link
Owner

iddan commented Aug 5, 2022

Published in v0.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong coordinates passed to onCellCommit?
3 participants