-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serde aux function to get names for fields as they are serialized #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple and fine with me. Probably we will just need to remove one line and address the clippy and formatting issues if they arise during the pipelines. Once everything is done, I'll merge. Thank you!
There are some unsuccessful pipelines. I suggest you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine in general, I can perform the minor fixes myself should you prefer.
Thank you for your contribution! :-)
Sure, edits by maintainer is checked for this PR. I didn't understand what you meant by the removing example colon so I left that to you, I saw it in other places? |
Yes, so in "cool" markdown, the colons after headers aren't welcomed, just a style. For example, here you won't see |
I'll merge once the checks are done. Thanks again! |
from serde-rs/serde#1110
Do you prefer a different method name?
I combined the function to get the field names from structs and enums so its easier to use. It was possible to use the wrong method for the type for the original implementation.
I will try address any comments.