Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde aux function to get names for fields as they are serialized #20

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

ta32
Copy link
Contributor

@ta32 ta32 commented Sep 6, 2021

from serde-rs/serde#1110

Do you prefer a different method name?

I combined the function to get the field names from structs and enums so its easier to use. It was possible to use the wrong method for the type for the original implementation.

I will try address any comments.

Copy link
Owner

@iddm iddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple and fine with me. Probably we will just need to remove one line and address the clippy and formatting issues if they arise during the pipelines. Once everything is done, I'll merge. Thank you!

src/lib.rs Outdated Show resolved Hide resolved
src/serde_introspection.rs Outdated Show resolved Hide resolved
@iddm
Copy link
Owner

iddm commented Sep 6, 2021

There are some unsuccessful pipelines. I suggest you run cargo clippy and cargo fmt locally and that will help you solve everything easily.

@ta32 ta32 requested a review from iddm September 8, 2021 02:18
Copy link
Owner

@iddm iddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in general, I can perform the minor fixes myself should you prefer.
Thank you for your contribution! :-)

src/lib.rs Outdated Show resolved Hide resolved
src/serde_introspection.rs Show resolved Hide resolved
src/serde_introspection.rs Outdated Show resolved Hide resolved
@ta32
Copy link
Contributor Author

ta32 commented Sep 8, 2021

Sure, edits by maintainer is checked for this PR.

I didn't understand what you meant by the removing example colon so I left that to you, I saw it in other places?
Feel free to make any more edits if you need to thanks :)

@iddm
Copy link
Owner

iddm commented Sep 8, 2021

Sure, edits by maintainer is checked for this PR.

I didn't understand what you meant by the removing example colon so I left that to you, I saw it in other places?
Feel free to make any more edits if you need to thanks :)

Yes, so in "cool" markdown, the colons after headers aren't welcomed, just a style. For example, here you won't see : after features or Optional features headers.

@iddm
Copy link
Owner

iddm commented Sep 8, 2021

I'll merge once the checks are done. Thanks again!

@iddm iddm merged commit 408c030 into iddm:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants