You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Checked that there is not already provided the described functionality
Description
prom2teams should be able to handle incoming messages no matter what attributes are received. For missing attributes that are required in the output, default values should be assigned.
The current list of mandatory attributes is too strict, since it for example includes instance which is not always sent.
Steps to Reproduce
Create an absent rule like IF absent(container_cpu_load_average_10s{name='mycriticalcontainer}) (cAdvisor) and the alert sent will not include the attribute instance
Expected behavior:
The alert should be sent with the available attributes filled out.
Actual behavior:
The alert from prom2teams to MS Teams will say Incorrect JSON received. At least one mandatory field (instance) is absent.
Reproduces how often:
All the time.
Versions
1.1.3
Additional Information
The text was updated successfully, but these errors were encountered:
Sometimes, an alert is generated without an instance.
For example if an alert is triggered when none of the monitored
instances has a particular property, such as the case when a vital
container is *not* running on any instance.
In this case, it makes sense to set the value of the `instance`
property to `none`, since it did not originate from a particular
intance.
This PR changes `intance` to an optional field, and sets a default value
to `none`.
Closesidealista#32
Prerequisites
Description
prom2teams should be able to handle incoming messages no matter what attributes are received. For missing attributes that are required in the output, default values should be assigned.
alertname='unknown'
status='firing'
instance='unknown'
summary='no alert summary specified'
The current list of mandatory attributes is too strict, since it for example includes instance which is not always sent.
Steps to Reproduce
Create an absent rule like
IF absent(container_cpu_load_average_10s{name='mycriticalcontainer})
(cAdvisor) and the alert sent will not include the attributeinstance
Expected behavior:
The alert should be sent with the available attributes filled out.
Actual behavior:
The alert from prom2teams to MS Teams will say
Incorrect JSON received. At least one mandatory field (instance) is absent.
Reproduces how often:
All the time.
Versions
1.1.3
Additional Information
The text was updated successfully, but these errors were encountered: