Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register /metrics endpoint when using --enablemetrics #207

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

vicsufer
Copy link
Collaborator

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

When -m or --enablemetrics flags an DEBUG_METRICS environment variable is set, this is to avoid a feature gate used in prometheus_flask_exporter to avoid registering /metrics endpoint when live reloading is enabled. FYI
Prom2Teams enabled live reloading in v2.0.4

Benefits

/metrics endpoint will be created even with live reloading enabled.

Possible Drawbacks

Future versions of prometheus_flask_exporter may give additional functionality to DEBUG_METRICS.

Applicable Issues

#201 /metrics server not working

@vicsufer vicsufer merged commit d5335c3 into develop Aug 21, 2020
@vicsufer vicsufer deleted the bugs/201 branch August 21, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants