Register /metrics endpoint when using --enablemetrics #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
When -m or --enablemetrics flags an
DEBUG_METRICS
environment variable is set, this is to avoid a feature gate used in prometheus_flask_exporter to avoid registering/metrics
endpoint when live reloading is enabled. FYIProm2Teams enabled live reloading in v2.0.4
Benefits
/metrics
endpoint will be created even with live reloading enabled.Possible Drawbacks
Future versions of prometheus_flask_exporter may give additional functionality to
DEBUG_METRICS
.Applicable Issues
#201 /metrics server not working