Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to webhook requests #219

Merged
merged 2 commits into from Oct 23, 2020

Conversation

DanSipola
Copy link
Contributor

@DanSipola DanSipola commented Oct 15, 2020

Add timeouts to webhook requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

I found the application in a state where it was logging messages like "uWSGI listen queue of socket full". There was a lot of connections to a uwsgi worker in close wait so I assume that over time network errors had accumulated connections to the point where the application would no longer serve requests from alertmanager.

Benefits

Possible Drawbacks

Might want the timeouts configurable, however I set them generous for the purpose of avoiding bad state.

Applicable Issues

@dortegau
Copy link
Member

Hi @DanSipola,

Thanks for your contribution! Could you describe the changes in the Changelog file?

@vicsufer vicsufer merged commit 87323aa into idealista:develop Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants