Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrying and limiting messages length when sending to teams #226

Merged
merged 9 commits into from Oct 27, 2020

Conversation

blalop
Copy link
Member

@blalop blalop commented Oct 22, 2020

Description of the Change

In the current state of prom2teams, there is nothing it can do to prevent missing Prometheus alerts due to several reasons, such as MS Teams being not available or prom2teams trying to send a payload that exceeds the limit MS Teams has.

Benefits

No alerts will be lost due to:

  • Teams being down
  • Sending a payload that is too long

Possible Drawbacks

None

Applicable Issues

#223

@blalop blalop self-assigned this Oct 22, 2020
@blalop blalop marked this pull request as ready for review October 23, 2020 12:29
@blalop blalop linked an issue Oct 23, 2020 that may be closed by this pull request
1 task
@vicsufer
Copy link
Collaborator

Question time, how is this interacting when using multiple connectors?

  • The same configuration is applied for all of them? (I think so)
  • If a request fails into one connector, the retry is only applied to this connector or will it trigger an unnecesary retry to the others?

@blalop
Copy link
Member Author

blalop commented Oct 26, 2020

Hi @vicsufer:

  • You're right, this PR does not provide per-connector configuration.
  • As the retry is managed at the teams client level - it has no knowledge of connectors. This means that it will only retry the failed connections.

README.md Show resolved Hide resolved
@dortegau dortegau merged commit a54d650 into develop Oct 27, 2020
@vicsufer vicsufer deleted the features/223 branch October 27, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry Policy
5 participants