Fixed exception error #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsufer
requested review from
blalop,
vicsufer,
dortegau,
emepege,
frantsao,
jmonterrubio,
jperera,
marcelogalmor,
sorobon,
ultraheroe and
xtianae7
|
Hi @nryabkov, thanks for spotting and fixing this! Could you please update the changelog to reflect the changes you've made? :) |
|
@blalop done - hope I did it correctly :) |
blalop
approved these changes
Oct 26, 2021
vicsufer
approved these changes
Oct 26, 2021
|
@blalop is it Sonarqube somehow misconfigured? Build complains on missing token 😬 |
|
@nryabkov We're aware, its a problem with forked repositories so don't worry. |
xtianae7
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Broken exception formatting leads to unknown errors in ms teams handling.
string.format created new instance which was never assigned to original value
Benefits
Extended logging simplifies debugging
Possible Drawbacks
None I know of
Applicable Issues
None