fix: get availability zone from data source

[ugmuka]

What does this PR do?

When creating subnet, availability zone is hard coded. Fixed to get availability zone parameters from data source.

Motivation

In certain region, <region>-b az is not available(ex ap-northeast-1b).

More

• Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• Yes, I ran pre-commit run -a with this PR

For Moderators

• E2E Test successfully complete before merge?

Additional Notes

[mgerlach]

Thanks for the contribution @ugmuka. Minor suggestions (as of the linter warnings).

[ugmuka]

Thanks, I signed off your suggestion.

[mgerlach]

Thanks, I signed off your suggestion.

Ok. Checks are looking good now.

Two more things to consider:

Is it safe that the AZs are always returned in the same (alphabetical?) order by the data source?

And do we need to exclude local zones (see https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/availability_zones.html and look for the example "Only availability zones (no local zones)") ?

Just want to make sure that users do not get unwanted changes due to changes of the AZs returned by the data source.

I am on a short leave from work these days, checking only occasionally. Back on Wednesday. My colleague Jakob @jdiebold may be available Mon/Tue.

[mgerlach]

@ugmuka just realized that my second question is not relevant as you used the group-name filter.

Regarding the first question, order of AZs, I'll make a code suggestion.

[mgerlach]

Suggesting to sort the az names retrieved from the data source.

Also, could you please sync your fork with idealo:main?

[mgerlach]

Hi @ugmuka , would my suggestions be ok? If yes, please apply them and rebase. Thx.

[ugmuka]

Sorry for the late reply, I signed off your commit.
If you want to rebase, I'll do it.

[github-actions]

🎉 This PR is included in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀