Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide input to associate additional security groups #88

Closed
wants to merge 2 commits into from
Closed

feat: Provide input to associate additional security groups #88

wants to merge 2 commits into from

Conversation

cmacrae
Copy link
Contributor

@cmacrae cmacrae commented Sep 7, 2022

These changes provide an additional_associated_security_group_ids input.
I see there's a PR action to automatically update the docs, so I've left those untouched :)

@cmacrae
feat: Provide input to associate additional security groups
3d3af44 
These changes provide an `additional_associated_security_group_ids` input.
mgerlach added a commit that referenced this pull request Sep 8, 2022
@mgerlach
feat: Provide input to associate additional security groups (#88 reba…
8dfc038 
…sed)
@mgerlach mgerlach mentioned this pull request Sep 8, 2022
Merged
@mgerlach
Copy link
Contributor

mgerlach commented Sep 8, 2022

Hi @cmacrae , thank you for your contribution! As we have merged other things and changed the variables.tf before, I copied your changes over to #92 - hope that's ok for you. Will merge and release as soon as @jdiebold has reviewed!

mgerlach added a commit that referenced this pull request Sep 8, 2022
@mgerlach @github-actions
feat: Provide input to associate additional security groups (#88 reba…
da5b328 
…sed) (#92)

* feat: Provide input to associate additional security groups (#88 rebased)

* terraform-docs: automated action

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mgerlach
Copy link
Contributor

mgerlach commented Sep 8, 2022

Released (#92) https://github.com/idealo/terraform-aws-mwaa/releases/tag/v2.1.0

@mgerlach mgerlach closed this Sep 8, 2022
@cmacrae
Copy link
Contributor Author

cmacrae commented Sep 13, 2022

Hey @mgerlach, yeah no problem! Thanks for reviewing and releasing these features (and for the module in the first place) 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdiebold jdiebold Awaiting requested review from jdiebold jdiebold is a code owner

@mgerlach mgerlach Awaiting requested review from mgerlach mgerlach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmacrae @mgerlach