Factorize static-site cards templates #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure the CSS class used is consistent with the package id. Plus add a new "info" theme, that was used before, but hacking the "learn" theme.
bochecha
approved these changes
Oct 6, 2016
There was a problem hiding this comment.
Nice, just like what @mgautierfr did for the Kiwix-based cards.
Looks good to me, but it would probably be better to wait for @mgautierfr's review, since he's the one who worked on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure the CSS class used is consistent with the
package id.
Plus add a new "info" theme, that was used before, but hacking
the "learn" theme.
Fixes #515