Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cycleway to directionalCombo #83

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Dec 28, 2022

Following the update in iD (https://github.com/openstreetmap/iD/pull/9423/files#diff-b3604385ed7e095c6c6fd1973a4c3d376f21e56f26452299a358d033411a38f6R65-R67) this changes the name of the field to make it reusable.

AFAIK this is all that needs to happen in this repo, right?

  • todo: Update version and date in Changelog.

Fixes #79

Rename `cycleway` to `directionalCombo`

Following the update in iD (https://github.com/openstreetmap/iD/pull/9423/files#diff-b3604385ed7e095c6c6fd1973a4c3d376f21e56f26452299a358d033411a38f6R65-R67) this changes the name of the field to make it reusable.

Fixes ideditor#79
tordans added a commit to tordans/id-tagging-schema that referenced this pull request Dec 28, 2022
@tyrasd tyrasd added the enhancement New feature or request label Jan 20, 2023
* this will likely get released as v6.0, as it's a basically breaking change
* the link to the readme is not needed IMO
@tyrasd tyrasd added this to the v6 milestone Jan 20, 2023
@tyrasd tyrasd merged commit 9745051 into ideditor:main Jan 20, 2023
@tyrasd
Copy link
Collaborator

tyrasd commented Jan 20, 2023

Update version and date in Changelog.

I'll do this before I package this into a release.

tyrasd added a commit that referenced this pull request Jan 20, 2023
* `key` is for the _common_ version of the tag (e.g. `*:both`)
* `keys` is for the _directional_ subtags (e.g. `*:left` / `*:right`)

refs #79, #83
@tyrasd
Copy link
Collaborator

tyrasd commented Jan 20, 2023

FYI: in 2714c23, I tweaked this one last time:

directionalCombo field: split keys into key and keys

  • key is for the common version of the tag (e.g. *:both)
  • keys is for the directional subtags (e.g. *:left / *:right)

for example, this is how the cycleway field looks now:

{
    "type": "directionalCombo",
    "label": "Bike Lanes",
    "key": "cycleway",
    "keys": [
        "cycleway:left",
        "cycleway:right"
    ],
  …
}

This is to make the implicit distinction between the common and directional subtags a bit more explicit (compared to relying on implicit order in keys).

@tordans tordans deleted the introduce-directioncombo branch January 20, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace cycleway with flexible directionalCombo field type
2 participants