Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5459 - Adapt Swing UI to refactoring of Payment Form (#1541) #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@
## Eclipse
* at your idempiere workspace, import existing projects from idempiere-swing-client
* run using swingclient.launch

NOTE!!

If you have run the server variant before, your idempiere.properties file is in the server's home directory.

The Swing Client will look for your idempiere.properties in $USER_HOME
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@
import org.compiere.util.Msg;
import org.compiere.util.ValueNamePair;

import bsh.engine.ScriptContextEngineView;

/**
* Create Manual Payments From (AP) Invoices or (AR) Credit Memos.
* Allows user to select Invoices for payment.
Expand Down Expand Up @@ -380,7 +382,7 @@ private void generatePaySelect()

ProcessParameterPanel pp = new ProcessParameterPanel(m_WindowNo, pi);
// Execute Process
ProcessCtl.process(this, m_WindowNo, (IProcessParameter) pp, pi, trx);
ProcessCtl.process(this, m_WindowNo, (IProcessParameter) pp, pi, null);
// ProcessCtl worker = new ProcessCtl(this, pi, trx);
// worker.start(); // complete tasks in unlockUI
} // generatePaySelect
Expand Down
17 changes: 0 additions & 17 deletions org.adempiere.ui.swing/src/org/compiere/grid/VPaymentFormCash.java
Original file line number Diff line number Diff line change
Expand Up @@ -129,23 +129,6 @@ public void loadData() {
// Accounting Date
bDateField.setValue(m_DateAcct);

// Is the currency an EMU currency?
Integer C_Currency_ID = Integer.valueOf(m_C_Currency_ID);
if (s_Currencies.containsKey(C_Currency_ID)) {
Enumeration<Integer> en = s_Currencies.keys();
while (en.hasMoreElements()) {
Object key = en.nextElement();
bCurrencyCombo.addItem(s_Currencies.get(key));
}
bCurrencyCombo.addActionListener(this);
bCurrencyCombo.setSelectedItem(s_Currencies.get(C_Currency_ID));
}
else // No EMU Currency
{
bCurrencyLabel.setVisible(false); // Cash
bCurrencyCombo.setVisible(false);
}

ArrayList<KeyNamePair> list = getBankAccountList();
for (KeyNamePair pp : list)
bBankAccountCombo.addItem(pp);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,25 +130,6 @@ public void loadData() {
sStatus.setText(m_mPayment.getR_PnRef());
sAmountField.setValue(m_mPayment.getPayAmt());
}

// Is the currency an EMU currency?
Integer C_Currency_ID = Integer.valueOf(m_C_Currency_ID);
if (s_Currencies.containsKey(C_Currency_ID))
{
Enumeration<Integer> en = s_Currencies.keys();
while (en.hasMoreElements())
{
Object key = en.nextElement();
sCurrencyCombo.addItem(s_Currencies.get(key));
}
sCurrencyCombo.addActionListener(this);
sCurrencyCombo.setSelectedItem(s_Currencies.get(C_Currency_ID));
}
else // No EMU Currency
{
sCurrencyLabel.setVisible(false); // Check
sCurrencyCombo.setVisible(false);
}

ArrayList<KeyNamePair> list = getBankAccountList();
for (KeyNamePair pp : list)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public void loadData() {
tStatus.setText(m_mPayment.getR_PnRef());
}

ArrayList<KeyNamePair> list = getBPBankAccountList();
ArrayList<KeyNamePair> list = getBankAccountList();
for (KeyNamePair pp : list)
tAccountCombo.addItem(pp);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ public void closeWindow()
public Object getWindow() {
return dialog;
}

@Override
protected void afterSave(boolean success) {
}
}