Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support W3C DID #452

Merged
merged 38 commits into from
Jul 27, 2023
Merged

support W3C DID #452

merged 38 commits into from
Jul 27, 2023

Conversation

olomix
Copy link
Contributor

@olomix olomix commented Apr 27, 2023

No description provided.

OBrezhniev and others added 21 commits April 15, 2023 03:07
@OBrezhniev
Add support for readonly and on-chain identities. Initial work on par…
c9b9fe9 
…sing of DIDs with other DID methods
@olomix
Create new type DID2 wich is a wrapper around github.com/build-trust/…
8874616 
…did compatible with old DID type
@olomix
Make Decompose method a separate function
8ef98d9
@olomix
Removed CoreID method from DID and replace id with helper function Co…
e44c464 
…reIDFromDID
@olomix
Get rid of ParseDID2 function
4a75c8f
@olomix
Remove SetString method for DID2
bdb5bd4
@olomix
Remove NetworkID & Blockchain DID2 methods. Use Decompose method inst…
d6b11aa 
…ead.
@olomix
Refactor similar code
d674dd3
@olomix
Remove NewDID2 function
991dbed
@olomix
Add missing error handling
c182c85
@olomix
Add missing error handling
e5cdaae
@olomix
Make linters happy
4cab3e2
@olomix
Remove custom DID type
008bab7
@olomix
Rename did.go to did2.go: prepare to include third-party DID implemen…
829f06b 
…tation
@olomix
Copy DID implementation from https://github.com/build-trust/did
fa7adeb
@olomix
Get rid of github.com/build-trust/did package. Copy implementation lo…
b67e018 
…cally.
@olomix
Remove unneeded type DID2
42f18ae
@olomix
Rename leftovers DID2 to DID
820a848
@olomix
Create new ID for unrecognized DID
a3e9ee6
@olomix
Wrap errors in more meaningful test
7993e5d
@olomix
Renamed files
a89f52b
@olomix olomix mentioned this pull request Apr 27, 2023
Closed
@olomix olomix changed the base branch from feature/onchain-and-other-dids to master May 2, 2023 19:18
vmidyllic
vmidyllic reviewed May 3, 2023
View reviewed changes
id.go Show resolved Hide resolved
id.go Outdated Show resolved Hide resolved
@olomix olomix marked this pull request as draft May 3, 2023 17:41
@olomix olomix marked this pull request as ready for review May 5, 2023 10:56
demonsh
demonsh previously approved these changes May 10, 2023
View reviewed changes
vmidyllic
vmidyllic previously approved these changes May 10, 2023
View reviewed changes
@olomix
Rename did package to w3c. Rename did.Parse function to w3c.ParseDID.…
42b31ff 
… Rename IdGenesisFromIdenState func to NewIDFromIdenState. Rename DIDGenesisFromIdenState to NewDIDFromIdenState. Rename DIDFromGenesis to NewDID.
@olomix olomix dismissed stale reviews from vmidyllic and demonsh via 42b31ff May 19, 2023 12:47
@ilya-korotya
Copy link
Contributor

The EthAddressFromID function is inconvenient because it returns the Ethereum address as an array of bytes. What is the correct way to convert these bytes into a string representation (e.g., string(contractAddress[:]))? If EthAddressFromID could directly return the string representation, it would be much more convenient.

vmidyllic
vmidyllic reviewed May 30, 2023
View reviewed changes
did.go Show resolved Hide resolved
vmidyllic
vmidyllic previously approved these changes Jul 20, 2023
View reviewed changes
@vmidyllic vmidyllic changed the title Create new type DID2 wich is a wrapper around github.com/build-trust/did compatible with old DID type support W3C DID Jul 27, 2023
@vmidyllic vmidyllic merged commit 49ea9a4 into master Jul 27, 2023
6 checks passed
@vmidyllic vmidyllic deleted the v2 branch July 27, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OBrezhniev OBrezhniev OBrezhniev left review comments

@demonsh demonsh demonsh approved these changes

@vmidyllic vmidyllic vmidyllic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olomix @ilya-korotya @demonsh @OBrezhniev @vmidyllic