Ensures public inputs are less than the scalar field size #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Jul 26, 2019
| @@ -182,11 +182,13 @@ contract Verifier { | |||
| <%vk_ic_pts%> | |||
| } | |||
| function verify(uint[] memory input, Proof memory proof) internal view returns (uint) { | |||
| uint256 snark_scalar_field = 21888242871839275222246405745257275088548364400416034343698204186575808495617; | |||
| VerifyingKey memory vk = verifyingKey(); | |||
| require(input.length + 1 == vk.IC.length,"verifier-bad-input"); | |||
| // Compute the linear combination vk_x | |||
| Pairing.G1Point memory vk_x = Pairing.G1Point(0, 0); | |||
| for (uint i = 0; i < input.length; i++) | |||
There was a problem hiding this comment.
I guess my tests were bad? Let me check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was first seen here: semaphore-protocol/semaphore#16
Based on the fix here: https://github.com/HarryR/ethsnarks/pull/141/files#diff-16b9d31d5ce4453863d191dd65657417R85