Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to new challenge URLs #1

Merged
merged 1 commit into from Dec 5, 2019
Merged

Change to new challenge URLs #1

merged 1 commit into from Dec 5, 2019

Conversation

robbertkl
Copy link
Contributor

It seems a couple of days ago the challenge URLs were changed. This PR addresses this (they simply got renamed from /challenge to /challenges.

It works for me when using the latest release (2.0.0-alpha.12) of magister.js and then manually changing challenge to challenges. I wanted to submit a PR there with the rename, but noticed that since the last release, the authentication was moved to (replaced by) this library, so now I created my PR here.

When trying to get everything working with magister.js master branch and this library I ran into some issues:

  • The auth code was not passed along and magister-openid introduced a breaking change in 0.1.4; I've solved this with this PR: Use authCode from config again simplyGits/MagisterJS#150
  • The challenge URLs were not correct (that's THIS PR)
  • Finally, it failed with TypeError: client_secret_basic client authentication method requires a client_secret in getTokenSet()

I haven't been able yet to solve this last error, but at least this PR gets it a few steps further down the authentication flow. I'll put the error in a separate issue. Please note I did not have this error when changing the challenge URL manually in an older version of magister.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants