Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support Angular 4 or Typescript versions below 2.4 #105

Closed
evanjmg opened this issue Oct 11, 2017 · 4 comments
Closed

Does not support Angular 4 or Typescript versions below 2.4 #105

evanjmg opened this issue Oct 11, 2017 · 4 comments

Comments

@evanjmg
Copy link

evanjmg commented Oct 11, 2017

Environment

  • Browser: All browsers
  • Version of smooth-scrollbar: Above 8.0.0

Issue Summary - Does not support Typescript below 2.4

ERROR in [at-loader] node_modules/smooth-scrollbar/track/direction.d.ts:2:9 
    In ambient enum declarations member initializer must be constant expression.

ERROR in [at-loader] node_modules/smooth-scrollbar/track/direction.d.ts:3:9 
    In ambient enum declarations member initializer must be constant expression.
webpack: bundle is now VALID.

This is a blocker for using the latest, current solution is to use version 7.

Current Behavior

Cannot build project

Expected Behavior

Should work on older Typescript versions as Angular 4 has not even upgraded to 2.4.

Steps to Reproduce

import * as ScrollBar from 'smooth-scrollbar' with Typescript version below 2.4

@idiotWu
Copy link
Owner

idiotWu commented Oct 12, 2017

😧 TypeScript 2.4 has been released for months but they do not support it yet??? That is too bad since I am a radical who is always excited about new features.

This is really a big blocker for me. I might not fix this issue until they roll out new release with latest TypeScript support.

@idiotWu idiotWu closed this as completed Oct 12, 2017
@idiotWu idiotWu reopened this Oct 12, 2017
@idiotWu
Copy link
Owner

idiotWu commented Oct 12, 2017

Oh sorry. Hit the close button by accident 😅

@idiotWu
Copy link
Owner

idiotWu commented Oct 12, 2017

It seems angular-cli has already supported TypeScript 2.4: angular/angular-cli#7578

So if you want to install ts 2.4 in your new project, the CLI itself won't stop you.

@idiotWu
Copy link
Owner

idiotWu commented Nov 12, 2017

angular-cli@1.5 supports ts 2.4 by default.

@idiotWu idiotWu closed this as completed Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants