Ensure that _validate_file check is run #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anand2312
reviewed
Oct 25, 2023
| @@ -37,9 +39,7 @@ def _validate_file(file: UploadFile) -> Literal[True]: | |||
|
|
|||
| async def _upload_to_storage(files: list[UploadFile], destination: str) -> list[str]: | |||
| for file in files: | |||
| if file.filename is None: | |||
| raise HTTPException(status_code=400, detail="No filename provided.") | |||
| _validate_file(file) | |||
There was a problem hiding this comment.
lmaoo who even wrote this in the first place
anand2312
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was at the wrong level of indentation and wouldn't have run on files as intended.
It is now at the correct level of indentation. Also, checking whether the filename is None has been moved inside
_validate_filecheck.