Skip to content

Commit

Permalink
Fixed deprecation warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
idlesign committed Oct 31, 2020
1 parent 45a5533 commit 2a3a4f5
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 13 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ django-sitegate changelog
=========================


Unreleased
----------
* Fixed deprecation warnings.


v1.2.0 [2020-05-29]
-------------------
! Dropped support for Django<2.0.
Expand Down
14 changes: 10 additions & 4 deletions sitegate/signals.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
"""This file contains signals emitted by sitegate."""
import django.dispatch

sig_user_signup_success = django.dispatch.Signal(providing_args=['signup_result', 'flow', 'request'])
"""Emitted when user successfully signs up."""
sig_user_signup_success = django.dispatch.Signal()
"""Emitted when user successfully signs up.
providing_args=['signup_result', 'flow', 'request']
sig_user_signup_fail = django.dispatch.Signal(providing_args=['signup_result', 'flow', 'request'])
"""Emitted when user sign up fails."""
"""

sig_user_signup_fail = django.dispatch.Signal()
"""Emitted when user sign up fails.
providing_args=['signup_result', 'flow', 'request']
"""
12 changes: 6 additions & 6 deletions sitegate/tests/testapp/urls.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
from django.conf.urls import url
from django.urls import path
from pytest_djangoapp.compat import get_urlpatterns

from sitegate.toolbox import get_sitegate_urls
from .views import login, register, HttpResponse


urlpatterns = get_urlpatterns([
url(r'entrance/', lambda r: None),
url(r'^ok/$', lambda r: HttpResponse('ok'), name='ok'),
url(r'^fail/$', lambda r: HttpResponse('fail'), name='fail'),
url(r'^login/$', login, name='login'),
url(r'^register/$', register, name='register'),
path('entrance/', lambda r: None),
path('ok/', lambda r: HttpResponse('ok'), name='ok'),
path('fail/', lambda r: HttpResponse('fail'), name='fail'),
path('login/', login, name='login'),
path('register/', register, name='register'),
] + get_sitegate_urls())
6 changes: 3 additions & 3 deletions sitegate/toolbox.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.conf.urls import url
from django.urls import re_path

from .views import verify_email

Expand All @@ -13,11 +13,11 @@ def get_sitegate_urls() -> list:
urlpatterns = patterns('',
...
url(r'^login/$', 'apps.views.login', name='login'),
path('login/', 'apps.views.login', name='login'),
...
) + get_sitegate_urls() # Attach.
"""
url_verify = url(r'^verify_email/(?P<code>\S+)/$', verify_email, name='verify_email')
url_verify = re_path(r'^verify_email/(?P<code>\S+)/$', verify_email, name='verify_email')

return [url_verify]

0 comments on commit 2a3a4f5

Please sign in to comment.