Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boostrab 3 submenu template #247

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Conversation

PetrDlouhy
Copy link
Contributor

PR for #246

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.892% when pulling 726cfde on PetrDlouhy:master into adfe591 on idlesign:master.

@@ -0,0 +1,14 @@
{% load sitetree %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this backup file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that shouldn't be there, of course.

@@ -0,0 +1,49 @@
// Taken from https://codepen.io/ajaypatelaj/pen/prHjD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be minified. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that we should keep the human-editable version of this file. So I can keep this and include also the minified version, although I don't think it is ideal due to code duplicity in the repo.
The ideal solution would be to compress the file in setup.py during packing.

Another possibility is to only suggest using django-compressor in the docs without dealing with the minification at all.

Constructs Bootstrap 3 menu with infinite submenus.
Requires adding extra CSS::

<link href="/static/css/sitetree_bootstrap_submenu.css" type="text/css" rel="stylesheet" media="screen">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/static/ shouldn't be harcoded, since it can change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, that is mistake.

Repository owner deleted a comment from coveralls Feb 6, 2018
Repository owner deleted a comment from coveralls Feb 6, 2018
@PetrDlouhy
Copy link
Contributor Author

@idlesign I fixed the obvious errors and suggested three possibilities for the minification. Pleas choose the best option, and I will update the PR by that.

@idlesign idlesign merged commit a8a07b1 into idlesign:master Feb 7, 2018
@idlesign
Copy link
Owner

idlesign commented Feb 7, 2018

Unminified will do. Merged.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants