-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add boostrab 3 submenu template #247
Conversation
@@ -0,0 +1,14 @@ | |||
{% load sitetree %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this backup file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that shouldn't be there, of course.
@@ -0,0 +1,49 @@ | |||
// Taken from https://codepen.io/ajaypatelaj/pen/prHjD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be minified. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, that we should keep the human-editable version of this file. So I can keep this and include also the minified version, although I don't think it is ideal due to code duplicity in the repo.
The ideal solution would be to compress the file in setup.py
during packing.
Another possibility is to only suggest using django-compressor
in the docs without dealing with the minification at all.
docs/source/templatesmod.rst
Outdated
Constructs Bootstrap 3 menu with infinite submenus. | ||
Requires adding extra CSS:: | ||
|
||
<link href="/static/css/sitetree_bootstrap_submenu.css" type="text/css" rel="stylesheet" media="screen"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/static/
shouldn't be harcoded, since it can change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, that is mistake.
@idlesign I fixed the obvious errors and suggested three possibilities for the minification. Pleas choose the best option, and I will update the PR by that. |
Unminified will do. Merged. |
PR for #246