Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed check_access() user reference #281

Closed
wants to merge 1 commit into from
Closed

Fixed check_access() user reference #281

wants to merge 1 commit into from

Conversation

Bartvaderkin
Copy link
Contributor

Changed check_access() to use the same user reference to retrieve permissions as used earlier in the method to check authentication

Using the context for the later check can break under certain conditions

@Bartvaderkin
Changed check_access() to use the same user reference to retrieve per…
70786a0 
…missions as used earlier in the method to check authentication

Using the context for the later check can break under certain conditions
@Bartvaderkin
Copy link
Contributor Author

Oops, wrong window, supposed to PR in our fork.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.179% when pulling 70786a0 on maykinmedia:fix/permission-user into 6c545b1 on idlesign:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bartvaderkin @coveralls