-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pronouns to Known profiles #1426
Conversation
@@ -0,0 +1,11 @@ | |||
<p class="p-pronoun pronoun small"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to be a microformats prescriptivist, but I don't think p-pronoun is a recognized/documented property for h-card.
Tried this out on https://known.kylewm.com/profile/kyle, lgtm! And the parsed version looks nice too: http://mf2.kylewm.com/?url=https%3A%2F%2Fknown.kylewm.com%2Fprofile%2Fkyle&parser=html5lib (with the exception of |
{ | ||
$pronoun = [ | ||
'oblique' => $this->getPronounOblique(), | ||
'nominative' => $this->getPronounNominative(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm used to seeing nominative first ("he/him/his" rather than "him/he/his")
Yep. Question, how will this connect with i18n? |
At HWC we discussed maybe using properties like Another possibility is determining the language of the containing element or document (using the lang attribute), but then {nominative, oblique, possessive} are almost certainly not sufficient for many other languages I know @voxpelli, @kevinmarks, and others have discussed how to mark up pages that have multiple languages within a single same page, but I'm not up to speed on those discussions. |
This is the related parsing brainstorm around languages: http://microformats.org/wiki/microformats2-parsing-brainstorming#Parse_language_information As there is a proper This could perhaps be a good example to document at the above page so that we can push the brainstorm around how to solve that issue further towards a solution? |
Thanks @voxpelli, I've added the brainstorming section you suggested: http://microformats.org/wiki/microformats2-parsing-brainstorming#Pronouns_in_different_languages I don't think we should block inclusion in Known on resolving those questions... The real-world publishing experience we get here will help inform the spec. |
This has been open for a while now... votes to merge? This'll have a visual change, so not just going ahead and doing it... |
This doesn't seem to be going anywhere, so closing. |
Here's what I fixed or added:
I added pronoun support for Known. Right now it needs to be manually added by setting
enable_pronouns=true
inconfig.ini
. Eventually, once we've arrived at a good way to display this, we should remove the config check and just make it live.Here's why I did it:
Pronouns are not a given and part of owning your own identity is having the right to state yours clearly.