Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pronouns to Known profiles #1426

Closed
wants to merge 5 commits into from
Closed

Add pronouns to Known profiles #1426

wants to merge 5 commits into from

Conversation

benwerd
Copy link
Member

@benwerd benwerd commented May 5, 2016

Here's what I fixed or added:

I added pronoun support for Known. Right now it needs to be manually added by setting enable_pronouns=true in config.ini. Eventually, once we've arrived at a good way to display this, we should remove the config check and just make it live.

Here's why I did it:

Pronouns are not a given and part of owning your own identity is having the right to state yours clearly.

@benwerd benwerd changed the title Benwerd pronoun Add pronouns to Known profiles May 5, 2016
@@ -0,0 +1,11 @@
<p class="p-pronoun pronoun small">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to be a microformats prescriptivist, but I don't think p-pronoun is a recognized/documented property for h-card.

@kylewm
Copy link
Collaborator

kylewm commented May 5, 2016

Tried this out on https://known.kylewm.com/profile/kyle, lgtm!

And the parsed version looks nice too: http://mf2.kylewm.com/?url=https%3A%2F%2Fknown.kylewm.com%2Fprofile%2Fkyle&parser=html5lib (with the exception of p-pronoun mentioned above)

{
$pronoun = [
'oblique' => $this->getPronounOblique(),
'nominative' => $this->getPronounNominative(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm used to seeing nominative first ("he/him/his" rather than "him/he/his")

@mapkyca
Copy link
Member

mapkyca commented May 7, 2016

Yep.

Question, how will this connect with i18n?

@kylewm
Copy link
Collaborator

kylewm commented May 7, 2016

At HWC we discussed maybe using properties like p-x-pronoun-en-nominative (or p-x-en-pronoun-nominative?)

Another possibility is determining the language of the containing element or document (using the lang attribute), but then {nominative, oblique, possessive} are almost certainly not sufficient for many other languages

I know @voxpelli, @kevinmarks, and others have discussed how to mark up pages that have multiple languages within a single same page, but I'm not up to speed on those discussions.

@voxpelli
Copy link

voxpelli commented May 7, 2016

This is the related parsing brainstorm around languages: http://microformats.org/wiki/microformats2-parsing-brainstorming#Parse_language_information

As there is a proper lang="en" attribute in HTML that already conveys the needed information I feel that something like <span class="p-x-pronoun-nominative" lang="en"> would be a much nicer solution than to introduce some kind of language into the class itself.

This could perhaps be a good example to document at the above page so that we can push the brainstorm around how to solve that issue further towards a solution?

@kylewm
Copy link
Collaborator

kylewm commented May 7, 2016

Thanks @voxpelli, I've added the brainstorming section you suggested: http://microformats.org/wiki/microformats2-parsing-brainstorming#Pronouns_in_different_languages

I don't think we should block inclusion in Known on resolving those questions... The real-world publishing experience we get here will help inform the spec.

@mapkyca
Copy link
Member

mapkyca commented Oct 24, 2016

This has been open for a while now... votes to merge?

This'll have a visual change, so not just going ahead and doing it...

@mapkyca
Copy link
Member

mapkyca commented Apr 20, 2017

This doesn't seem to be going anywhere, so closing.

@mapkyca mapkyca closed this Apr 20, 2017
@mapkyca mapkyca deleted the benwerd-pronoun branch September 3, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants