Checkins plugin won't show maps over https

[obra]

It depends on leaflet and stamen maps being served over http. stamen maps don't appear to have an ssl option :(

[obra]

Stamen maps now has an SSL option. Switching to always use maps over SSL is an "easy" change, but it looks like including leaflet is the recommended way to deal with maybe serving over SSL - should I be putting it in the top level external or is there a place for plugins to add assets?

[benwerd]

I've been including a folder in each plugin for external libraries. Working on this right now - have flipped over to using local Leaflet, haven't quite got it working yet.

[benwerd]

Okay, it's now there. Please test!

[obra]

On Wed, Aug 14, 2013 at 08:06:11PM -0700, Ben Werdmuller wrote:

I've been including a folder in each plugin for external libraries. Working on this right now - have flipped over to using local Leaflet, haven't quite got it working yet.

nod I believe you want to switch the stamen maps to pull from:
https://stamen-tiles.a.ssl.fastly.net per maps.stamen.com/#SSL

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[benwerd]

Aha, thank you. Okay, it's ugly but there's a fix in place.

[obra]

On Wed, Aug 14, 2013 at 08:19:22PM -0700, Ben Werdmuller wrote:

Aha, thank you. Okay, it's ugly but there's a fix in place.

Cool. Is there a reason to not always just use the SSL version of the tiles?

[obra]

Ack, no, the fastly cache only serves up the tiles, not the js

On Wed, Aug 14, 2013 at 08:19:22PM -0700, Ben Werdmuller wrote:

Aha, thank you. Okay, it's ugly but there's a fix in place.

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[benwerd]

Did the latest commits help?

[obra]

Yes. This is all set, now.

https://s.ly/view/520bb3bb6819dc300a4cffc4

On Thu, Aug 15, 2013 at 02:46:33PM -0700, Ben Werdmuller wrote:

Did the latest commits help?

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[benwerd]

Wicked cool. Thanks! Closing the ticket.