Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Reply to Site on a Status Post results in Javascript error. #2731

Closed
lindner opened this issue Apr 12, 2020 · 5 comments
Closed

Using Reply to Site on a Status Post results in Javascript error. #2731

lindner opened this issue Apr 12, 2020 · 5 comments

Comments

@lindner
Copy link
Collaborator

lindner commented Apr 12, 2020

While trying to do this:

Clicking Reply to Site when creating a Status post.

I encountered this error:

A javascript error when using known.min.js

ERROR: SyntaxError: missing ) after argument list known.min.js:formatted:57
    log known.min.js:57
    errorHandler known.min.js:98
    <anonymous> known.min.js:101

The stack trace is swallowed, but I think that's because this is coming from the onclick javascript...

When not using known.min.js you see incorrectly escaped text in the URL box that has a backslash Add the URL that you\'re replying to as the placeholder text.

Some other notes:

  • latest github checkout.
  • Appears to be in this file IdnoPlugins/Status/templates/default/entity/Status/edit.tpl.php
@mapkyca
Copy link
Member

mapkyca commented Apr 13, 2020

Are you using the latest versions of core and the plugins? Pretty sure I've fixed this already...

@mapkyca
Copy link
Member

mapkyca commented Apr 14, 2020

You should also make sure you've done a composer install after updating, as the fix was in the status plugin itself

@cdn
Copy link
Contributor

cdn commented Apr 15, 2020

Are you using the latest versions of core and the plugins? Pretty sure I've fixed this already...

idno/status#5

@mapkyca mapkyca closed this as completed Apr 17, 2020
@lindner
Copy link
Collaborator Author

lindner commented Apr 17, 2020 via email

@mapkyca
Copy link
Member

mapkyca commented Apr 17, 2020

Yeah, sorry! There are a lot of plugins now :)

If you're running off a git checkout, get in the habit of doing a composer update after! I'll try and make sure I tag things a little more often as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants